Bug 98526

Summary: [chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
Product: WebKit Reporter: Terry Anderson <tdanderson>
Component: PlatformAssignee: Terry Anderson <tdanderson>
Status: RESOLVED FIXED    
Severity: Normal CC: behdad, rbyers, reed, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98166    
Attachments:
Description Flags
Patch none

Terry Anderson
Reported 2012-10-05 08:53:10 PDT
This is causing some problems with picture serialization between chrome and the mainline skia tools. (Once this change lands and is gardened in, I will make the corresponding change in chromium/skia/skia.gyp)
Attachments
Patch (1.67 KB, patch)
2012-10-05 08:54 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Terry Anderson
Comment 1 2012-10-05 08:54:24 PDT
Created attachment 167333 [details] Patch
Mike Reed
Comment 2 2012-10-05 09:12:19 PDT
does this also require a similar change to chrome/src/skia/skia.gyp, or is this CL sufficient?
Mike Reed
Comment 3 2012-10-05 09:12:33 PDT
doh, I didn't read the first comment. sorry :)
Stephen White
Comment 4 2012-10-05 12:57:57 PDT
Comment on attachment 167333 [details] Patch OK. r=me
WebKit Review Bot
Comment 5 2012-10-05 15:05:46 PDT
Comment on attachment 167333 [details] Patch Clearing flags on attachment: 167333 Committed r130558: <http://trac.webkit.org/changeset/130558>
WebKit Review Bot
Comment 6 2012-10-05 15:05:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.