Bug 98520

Summary: Web Inspector: Semantically incorrect CSS rules result in broken source code data
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, cmarcelo, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98246    
Attachments:
Description Flags
Patch none

Description Alexander Pavlov (apavlov) 2012-10-05 08:09:37 PDT
For example, an @import rule following a style rule results in inability to edit all following style rules through the model.
Comment 1 Alexander Pavlov (apavlov) 2012-10-05 09:37:04 PDT
Created attachment 167338 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-10-05 09:44:16 PDT
Comment on attachment 167338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167338&action=review

> Source/WebCore/css/CSSParser.cpp:10134
> +        popRuleData();

Is this one tested?
Comment 3 Alexander Pavlov (apavlov) 2012-10-05 10:49:23 PDT
Comment on attachment 167338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167338&action=review

>> Source/WebCore/css/CSSParser.cpp:10134
>> +        popRuleData();
> 
> Is this one tested?

The "if (pageSelector)" check is extraneous - the grammar guarantees that we never get a NULL pageSelector. I added the call for consistency.
Comment 4 WebKit Review Bot 2012-10-10 03:50:12 PDT
Comment on attachment 167338 [details]
Patch

Clearing flags on attachment: 167338

Committed r130883: <http://trac.webkit.org/changeset/130883>
Comment 5 WebKit Review Bot 2012-10-10 03:50:16 PDT
All reviewed patches have been landed.  Closing bug.