Bug 98512
| Summary: | [Qt] Incremental build bug revealed by r130496 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | hausmann, vestbo |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 420+ | ||
| Hardware: | All | ||
| OS: | All | ||
Csaba Osztrogonác
https://trac.webkit.org/changeset/130496 rolled out r130495
and it caused build fail on all bots. It is an incremental
build bug, because clean build works fine.
build log: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release/builds/43465/steps/compile-webkit/logs/stdio
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Hausmann
Interesting. The patch _does_ move a class from WK1 into WebCore:
/ramdisk/qt-linux-64-release/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(RenderThemeQStyle.o): In function `WebCore::RenderThemeQStyle::inflateButtonRect(QRect const&) const':
RenderThemeQStyle.cpp:(.text._ZNK7WebCore17RenderThemeQStyle17inflateButtonRectERK5QRect+0x0): multiple definition of `WebCore::RenderThemeQStyle::inflateButtonRect(QRect const&) const'
/ramdisk/qt-linux-64-release/build/WebKitBuild/Release/Source/WebKit/release/libWebKit1.a(RenderThemeQStyle.o):RenderThemeQStyle.cpp:(.text._ZNK7WebCore17RenderThemeQStyle17inflateButtonRectERK5QRect+0x0): first defined here
It looks almost as if it didn't get thrown out.
Simon Hausmann
It seems that what happened was that a file was removed from WebCore but libWebCore.a wasn't relinked.
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.