Bug 98492

Summary: Web Inspector: More granular filtering on message type.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Dmitry Zvorygin <zvorygin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: addyo, burg, dubroy, japhet, mkwst+watchlist, paulirish, pfeldman, vivekgalatage, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Sample screenshot.
none
Sample screenshot.
none
Patch
pfeldman: review-
Decreased checkbox size and lighter dropdown arrow separator. none

Description Mike West 2012-10-05 00:44:25 PDT
Report from a user:
-------------------

"Please let the Errors Warnings and Logs behave like checkboxes instead of radio buttons. For instance when you want to see Errors *and* Logs but not Warnings."
Comment 1 Vivek Galatage 2012-10-05 13:40:56 PDT
(In reply to comment #0)
> Report from a user:
> -------------------
> 
> "Please let the Errors Warnings and Logs behave like checkboxes instead of radio buttons. For instance when you want to see Errors *and* Logs but not Warnings."

Is this referring to the console panel? If yes then we already support this with help of meta key press (ctrl in case of linux/windows) + click. We can selectively click while having the meta key pressed. Correct me if I am wrong.
Comment 2 Mike West 2013-01-24 06:10:38 PST
*** Bug 107704 has been marked as a duplicate of this bug. ***
Comment 3 Mike West 2013-01-24 06:29:52 PST
Widening the scope of this bug a bit: we have "sources" and "severities". It should be possible to filter on both.

Pavel's suggestion: "I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source)."
Comment 4 Mike West 2013-01-24 06:34:41 PST
Slightly more explanation:

Console messages have (at least) two properties that are interesting: "source" and "level". Currently, we offer filtering on the latter via the weird "Error", "Warning", "Log", "Debug" quasi-checkboxes at the bottom of the console. We offer no filtering on the former (which includes sources like "HTML", "JS", "Network", "XML", and "Other"). Based on some discussion in https://bugs.webkit.org/show_bug.cgi?id=107704, it seems like we should.

I'd like to come up with some sort of UI that reasonably presents this matrix of filters to users.
Comment 5 Addy Osmani 2013-01-24 06:39:36 PST
> we already support this with help of meta key press (ctrl in case of linux/windows) + click

On the narrower scope: I agree with Mike that checkboxes would be more intuitive - until Vivek mentioned we supported multiple selection via ctrl + click, I had no idea this was supported. Something more user-friendly would almost certainly be better.

> I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source)

Is it possible to see a rough mock-up for what this might look like? :) In my mind it feels overly complex, but my visualization may be incorrect.
Comment 6 Addy Osmani 2013-01-24 06:41:03 PST
> We offer no filtering on the former (which includes sources like "HTML", "JS", "Network", "XML", and "Other")

Agreed that filtering on these messages would be useful. I'm surprised this isn't currently supported to be honest.
Comment 7 Dmitry Zvorygin 2013-03-15 04:33:13 PDT
Created attachment 193279 [details]
Patch
Comment 8 Vsevolod Vlasov 2013-03-18 00:32:39 PDT
Comment on attachment 193279 [details]
Patch

Could you please attach screenshots?
Comment 9 Dmitry Zvorygin 2013-03-18 04:40:46 PDT
Created attachment 193528 [details]
Sample screenshot.
Comment 10 Dmitry Zvorygin 2013-03-18 04:41:23 PDT
Created attachment 193529 [details]
Sample screenshot.

Please note, that checkbox at "Other" has gone away.
Comment 11 Dmitry Zvorygin 2013-03-19 03:49:31 PDT
Created attachment 193777 [details]
Patch
Comment 12 Dmitry Zvorygin 2013-03-19 03:51:36 PDT
Created attachment 193778 [details]
Decreased checkbox size and lighter dropdown arrow separator.
Comment 13 Pavel Feldman 2013-03-19 09:36:56 PDT
The font should be on "0 of 0" (i.e. smaller). Also, you should check the looks on a Mac.
Comment 14 Pavel Feldman 2013-03-19 09:45:21 PDT
(In reply to comment #13)
> The font should be on "0 of 0" (i.e. smaller). Also, you should check the looks on a Mac.

(sorry, wrong bug)
Comment 15 Pavel Feldman 2013-03-19 09:48:01 PDT
Comment on attachment 193777 [details]
Patch

You should split this change into 1) the one normalizing the levels 2) migrating to the non-CSS filtering 3) introducing new UI widgets. Also, please decrease the font 1px for the filter labels.
Comment 16 Brian Burg 2014-12-01 14:31:16 PST
Current inspector supports multiple selection.