Bug 98489

Summary:

[GTK] Add support for GBytes in GRefPtr

Product:

WebKit

Reporter:

Simon Pena <spena>

Component:

WebKitGTK

Assignee:

Simon Pena <spena>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cgarcia, mrobinson, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

98494

Bug Blocks:

98488

Attachments:

Description	Flags
Patch	none
Patch	none

Simon Pena

Reported 2012-10-04 23:52:52 PDT

GResources add support for embedding resources in the binaries, and can later be loaded as GBytes. Supporting GBytes inside GRefPtr is more consistent with the rest of the port, and makes it easier for the GResources support.

Attachments
Patch (2.81 KB, patch) 2012-10-05 00:08 PDT, Simon Pena	no flags	Details Formatted Diff Diff
Patch (3.10 KB, patch) 2012-10-05 01:50 PDT, Simon Pena	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Pena

Comment 1 2012-10-05 00:08:06 PDT

Created attachment 167266 [details] Patch

Carlos Garcia Campos

Comment 2 2012-10-05 00:17:09 PDT

Comment on attachment 167266 [details] Patch Perfect

WebKit Review Bot

Comment 3 2012-10-05 00:40:09 PDT

Comment on attachment 167266 [details] Patch Clearing flags on attachment: 167266 Committed r130478: <http://trac.webkit.org/changeset/130478>

WebKit Review Bot

Comment 4 2012-10-05 00:40:12 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2012-10-05 01:07:26 PDT

Re-opened since this is blocked by bug 98494

Csaba Osztrogonác

Comment 6 2012-10-05 01:10:50 PDT

(In reply to comment #5) > Re-opened since this is blocked by bug 98494 Rolled out, beacuse it broke the Qt build: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function ‘T* WTF::refGPtr(T*) [with T = _GBytes]’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp:69:24: error: ‘g_bytes_ref’ was not declared in this scope /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function ‘void WTF::derefGPtr(T*) [with T = _GBytes]’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp:76:26: error: ‘g_bytes_unref’ was not declared in this scope

Simon Pena

Comment 7 2012-10-05 01:50:07 PDT

Created attachment 167282 [details] Patch

Carlos Garcia Campos

Comment 8 2012-10-05 03:04:27 PDT

Comment on attachment 167282 [details] Patch Everything is green now, let's try again.

WebKit Review Bot

Comment 9 2012-10-05 03:23:07 PDT

Comment on attachment 167282 [details] Patch Clearing flags on attachment: 167282 Committed r130491: <http://trac.webkit.org/changeset/130491>

WebKit Review Bot

Comment 10 2012-10-05 03:23:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.