Bug 9848

Summary: Teach svn-create-patch and friends to fix ChangeLog patches
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch v1
none
Patch v2 darin: review+

David Kilzer (:ddkilzer)
Reported 2006-07-11 03:37:27 PDT
The svn-create-patch utility needs to "fix" ChangeLog patches that don't position new entries at the top of the file.  (See Attachment 9359 [details] on Bug 9598 for one of many examples.)  I plan to fix this by special-casing ChangeLog patches and fixing them if they don't behave. Until this is fixed, such ChangeLog patches tend to get offset into the ChangeLog (instead of being applied at the top) and the fix-ChangeLog-date code (Bug 9693) will apply the date to the wrong entry.
Attachments
Patch v1 (10.78 KB, patch)
2006-07-12 06:38 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (11.03 KB, patch)
2006-07-12 06:50 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-07-11 07:03:32 PDT
In the shower, I realized that svn-apply and svn-unapply also need to deal with "bad" ChangeLog patches in case someone uses plain old "svn diff" to create their patch, or used an older version of svn-create-patch that didn't do the fixing. I think I can write one subroutine to do the fixing and add to all three scripts, though.
David Kilzer (:ddkilzer)
Comment 2 2006-07-12 06:38:14 PDT
Created attachment 9400 [details] Patch v1 Proposed patch.
David Kilzer (:ddkilzer)
Comment 3 2006-07-12 06:50:15 PDT
Created attachment 9401 [details] Patch v2 Changes from Patch v1: - Removed magic number, "3", and replaced it with a named variable in all three scripts.
Darin Adler
Comment 4 2006-07-12 08:07:54 PDT
Comment on attachment 9401 [details] Patch v2 Neat. As these get fancier and fancier, eventually we *will* want to start using a library. But for now I still think it's OK to have 3 copies.
David Kilzer (:ddkilzer)
Comment 5 2006-07-12 09:09:40 PDT
Committed revision 15393.
Note You need to log in before you can comment on or make changes to this bug.