Bug 98438

Summary: MutationRecord attributeName should be null for non attribute changes
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: DOMAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, ojan, rafaelw, rniwa, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Erik Arvidsson
Reported 2012-10-04 12:26:59 PDT
We return '' instead of null for atributeName when the type is characterData (I didn't try childNodes but I assume we have the same issue there and other places). Steps to reproduce var text = document.createTextNode('abc'); var observer = new WebKitMutationObserver(function() {}); observer.observe(text, { characterData: true }); text.data = 'def'; var records = observer.takeRecords(); shouldBeNull('record[0].attributeName');
Attachments
Patch (4.96 KB, patch)
2012-10-04 14:57 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-10-04 12:50:19 PDT
Also see bug 98439 which is about oldValue not being null when expected
Adam Klein
Comment 2 2012-10-04 13:50:59 PDT
I'll take both this and 98439 (will fix them in the same patch).
Adam Klein
Comment 3 2012-10-04 14:57:56 PDT
Created attachment 167181 [details] Patch
WebKit Review Bot
Comment 4 2012-10-04 18:02:20 PDT
Comment on attachment 167181 [details] Patch Clearing flags on attachment: 167181 Committed r130442: <http://trac.webkit.org/changeset/130442>
WebKit Review Bot
Comment 5 2012-10-04 18:02:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.