Bug 9843

Summary:

Give Netscape plug-ins access to their own DOM element

Product:

WebKit

Reporter:

Tim Omernick <timo>

Component:

Plug-ins

Assignee:

Tim Omernick <timo>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

9844

Bug Blocks:

Attachments:

Description	Flags
Patch and layout test	ggaren: review-
the lost WebKit part	ggaren: review+
Move NPObject creation out of Frame, into HTMLPlugInElement	andersca: review-
try and try again	andersca: review+

Tim Omernick

Reported 2006-07-10 23:27:13 PDT

This is already part of the Netscape API; we just haven't implement it yet. See <rdar://problem/4480187>.

Attachments
Patch and layout test (11.36 KB, patch) 2006-07-10 23:54 PDT, Tim Omernick	ggaren: review-	Details Formatted Diff Diff
the lost WebKit part (5.74 KB, patch) 2006-07-11 00:26 PDT, Tim Omernick	ggaren: review+	Details Formatted Diff Diff
Move NPObject creation out of Frame, into HTMLPlugInElement (10.95 KB, patch) 2006-07-11 16:02 PDT, Tim Omernick	andersca: review-	Details Formatted Diff Diff
try and try again (10.47 KB, patch) 2006-07-11 16:41 PDT, Tim Omernick	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Omernick

Comment 1 2006-07-10 23:54:12 PDT

Created attachment 9355 [details] Patch and layout test

Geoffrey Garen

Comment 2 2006-07-11 00:18:32 PDT

Comment on attachment 9355 [details] Patch and layout test We talked about this on IRC. Tim is going to move the implementation of createNPObjectForElement into the element class, and out of Frame.

Tim Omernick

Comment 3 2006-07-11 00:26:11 PDT

Created attachment 9358 [details] the lost WebKit part I forgot the WebKit part. Here it is.

Geoffrey Garen

Comment 4 2006-07-11 00:29:12 PDT

Comment on attachment 9358 [details] the lost WebKit part r=me

David Kilzer (:ddkilzer)

Comment 5 2006-07-11 03:42:59 PDT

Patch committed in r15331 by timo.

David Kilzer (:ddkilzer)

Comment 6 2006-07-11 03:44:29 PDT

(In reply to comment #5) > Patch committed in r15331 by timo. Oops! That was Bug 9844. Reopening this bug until patch is applied.

Tim Omernick

Comment 7 2006-07-11 16:02:13 PDT

Created attachment 9381 [details] Move NPObject creation out of Frame, into HTMLPlugInElement

Anders Carlsson

Comment 8 2006-07-11 16:27:32 PDT

Comment on attachment 9381 [details] Move NPObject creation out of Frame, into HTMLPlugInElement I discussed some possible changes to the patch with Tim O on IRC

Tim Omernick

Comment 9 2006-07-11 16:41:47 PDT

Created attachment 9382 [details] try and try again Made the change that Anders suggested -- removed Element::getNPObject(). Now the ObjC DOM code explicitly checks for applet, embed, and object elements.

Anders Carlsson

Comment 10 2006-07-11 16:45:35 PDT

Comment on attachment 9382 [details] try and try again r=me

Note You need to log in before you can comment on or make changes to this bug.