Unprefix the flexbox CSS properties

• Component: CSS
• Status: RESOLVED FIXED

[Ojan Vafai]

At this point we're just waiting for another browser vendor to ship the new flexboxes so that we can do some basic compatibility testing. None of the remaining open bugs at https://bugs.webkit.org/showdependencytree.cgi?id=62048&hide_resolved=1 seem worth stalling unprefixing on.

[Tony Chang]

It was just enabled in mozilla-inbound (https://wiki.mozilla.org/Tree_Rules/Inbound):
https://bugzilla.mozilla.org/show_bug.cgi?id=666041#c124

[Glenn Adams]

has the CSS WG resolved to unprefix flexbox yet? if not, should we WK jump the gun on them?

[Tab Atkins]

(In reply to comment #2)
> has the CSS WG resolved to unprefix flexbox yet? if not, should we WK jump the gun on them?

Flexbox is in CR, which by definition means that we're okay with unprefixing.

[Glenn Adams]

(In reply to comment #3)
> (In reply to comment #2)
> > has the CSS WG resolved to unprefix flexbox yet? if not, should we WK jump the gun on them?
> 
> Flexbox is in CR, which by definition means that we're okay with unprefixing.

excellent

[Paul Irish]

Update: It's now landed in FF nightly builds: http://blog.dholbert.org/2012/12/css3-flexbox-enabled-in-nightlies-ready.html

[Binyamin]

Landed in FF19 https://bugzilla.mozilla.org/show_bug.cgi?id=801098

[Michał Gołębiowski-Owczarek]

Both Firefox & Chrome have unprefixed Flexbox properties already, the same stands for the IE11 beta. Is there anything blocking unprefixing in WebKit?

[Michał Gołębiowski-Owczarek]

Worth noting is that both Firefox & Chrome have unprefixed Flexbox in their stable versions not just nightlies. So it's 3 browsers in stable versions (Opera 15 included) and IE in a preview. WebKit is the last to keep prefixes.

Considering WebKit Flexbox implementation seems stable and is richer than Firefox one, I think it'd be nice to unprefix in time for Safari 6.1/7 (and maybe iOS7?), it would make web developers' lives a little bit easier.

[Michał Gołębiowski-Owczarek]

Sorry, it seems I lied about Chrome having uprefixed flexbox in stable (v28), though it seems to have it in beta (v29) according to:
https://code.google.com/p/chromium/issues/detail?id=249111
and I can confirm it's present in Canary (v30)

[Radar WebKit Bug Importer]

<rdar://problem/14835804>

[Michał Gołębiowski-Owczarek]

What's the status of this bug? All other browsers have unprefixed Flexbox more than 10 months ago in their stable versions and in Safari it will happen not sooner than in a year; it's almost a two-years gap!

Is there anything blocking unprefixing?

[Dean Jackson]

(In reply to comment #11)
> What's the status of this bug? All other browsers have unprefixed Flexbox more than 10 months ago in their stable versions and in Safari it will happen not sooner than in a year; it's almost a two-years gap!
> 
> Is there anything blocking unprefixing?

Nope. I'm taking it on now.

[Dean Jackson]

Created attachment 238044 [details]
Patch

[Benjamin Poulain]

(In reply to comment #12)
> (In reply to comment #11)
> > What's the status of this bug? All other browsers have unprefixed Flexbox more than 10 months ago in their stable versions and in Safari it will happen not sooner than in a year; it's almost a two-years gap!
> > 
> > Is there anything blocking unprefixing?
> 
> Nope. I'm taking it on now.

IMHO, we should also import all the flexbox tests from blink.

[Tony Chang]

Comment on attachment 238044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238044&action=review

> Source/WebCore/ChangeLog:20
> +        - justify

justify-content

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:292
> +    CSSPropertyJustifySelf,

justify-self seems to be part of the CSS Alignment spec, not the flexbox spec.  Did you mean to include this change?  http://dev.w3.org/csswg/css-align/

[Dean Jackson]

(In reply to comment #15)
> (From update of attachment 238044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238044&action=review
> 
> > Source/WebCore/ChangeLog:20
> > +        - justify
> 
> justify-content

Yes.

> 
> > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:292
> > +    CSSPropertyJustifySelf,
> 
> justify-self seems to be part of the CSS Alignment spec, not the flexbox spec.  Did you mean to include this change?  http://dev.w3.org/csswg/css-align/

You're right, thanks!

[WebKit Commit Bot]

Comment on attachment 238044 [details]
Patch

Clearing flags on attachment: 238044

Committed r173572: <http://trac.webkit.org/changeset/173572>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Dean Jackson]

Committed r173579: <http://trac.webkit.org/changeset/173579>