Bug 98346

Summary:

XvfbDriver unit test is flaky on Linux builders

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

Tools / Tests

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, kkristof, ojan, ossy, pnormand, rakuco, spenap, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

88414

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2012-10-04 00:07:46 PDT

The XvfbDriver unit tests have been failing flakily ever since update in r129891.
http://trac.webkit.org/changeset/129891

Examples:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/37294/steps/webkitpy-test/logs/stdio
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/37292/steps/webkitpy-test/logs/stdio
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/37289/steps/webkitpy-test/logs/stdio

The test is passing without problems on GTK 64-bit release builder but I have spotted some failures of the same type on the EFL 64-bit debug builder:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/6729/steps/webkitpy-test/logs/stdio
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/6714/steps/webkitpy-test/logs/stdio
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/6691/steps/webkitpy-test/logs/stdio

... and even on the Qt Linux Release builder:
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/52848/steps/webkitpy-test/logs/stdio
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/52842/steps/webkitpy-test/logs/stdio

Comment 1 Zan Dobersek 2012-10-04 02:47:23 PDT

Changing the title to a more proper format.

Comment 2 Zan Dobersek 2012-10-09 11:38:08 PDT

Created attachment 167804 [details]
Patch

Comment 3 Adam Barth 2012-10-09 11:43:16 PDT

Comment on attachment 167804 [details]
Patch

ok.  thanks.

Comment 4 WebKit Review Bot 2012-10-09 12:23:05 PDT

Comment on attachment 167804 [details]
Patch

Clearing flags on attachment: 167804

Committed r130792: <http://trac.webkit.org/changeset/130792>

Comment 5 WebKit Review Bot 2012-10-09 12:23:09 PDT

All reviewed patches have been landed.  Closing bug.