Bug 98342

Summary: REGRESSION (r129989 - r130019): [WK2] TestResources test is failing
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mario, mrobinson, spena, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Try to fix the errors loading the favicon mrobinson: review+

Zan Dobersek
Reported 2012-10-03 23:46:25 PDT
The TestResources unit test is failing, first starting doing so here: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/29211 Output for this test: TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/WebKit2APITests/TestResources... (pid=9982) /webkit2/WebKitWebResource/loading: ** ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:344:void testWebResourceLoading(SingleResourceLoadTest*, gconstpointer): assertion failed (events.size() == 4): (6 == 4) FAIL Suspect revisions are: http://trac.webkit.org/changeset/129992 http://trac.webkit.org/changeset/129994
Attachments
Try to fix the errors loading the favicon (8.85 KB, patch)
2012-10-05 05:22 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-10-03 23:58:27 PDT
The failure in debug build is a bit different: TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Debug/Programs/WebKit2APITests/TestResources... (pid=20594) /webkit2/WebKitWebResource/loading: ERROR: Failed to start load for icon at url http://127.0.0.1:46786/favicon.ico ../../Source/WebCore/loader/icon/IconLoader.cpp(73) : void WebCore::IconLoader::startLoading() ERROR: Failed to start load for icon at url http://127.0.0.1:46786/favicon.ico ../../Source/WebCore/loader/icon/IconLoader.cpp(73) : void WebCore::IconLoader::startLoading() OK /webkit2/WebKitWebResource/response: ERROR: Failed to start load for icon at url http://127.0.0.1:46786/favicon.ico ../../Source/WebCore/loader/icon/IconLoader.cpp(73) : void WebCore::IconLoader::startLoading() ERROR: Failed to start load for icon at url http://127.0.0.1:46786/favicon.ico ../../Source/WebCore/loader/icon/IconLoader.cpp(73) : void WebCore::IconLoader::startLoading() ERROR: Failed to start load for icon at url http://127.0.0.1:46786/favicon.ico ../../Source/WebCore/loader/icon/IconLoader.cpp(73) : void WebCore::IconLoader::startLoading() ** (./Tools/gtk/../Scripts/../../WebKitBuild/Debug/Programs/WebKit2APITests/TestResources:20594): CRITICAL **: guint webkit_uri_response_get_status_code(WebKitURIResponse*): assertion `WEBKIT_IS_URI_RESPONSE(response)' failed FAIL
Carlos Garcia Campos
Comment 2 2012-10-04 00:09:34 PDT
We probably need to update some unit tests to handle /favicon.icon requests in the soup server to return a 404. I'll look at it.
Carlos Garcia Campos
Comment 3 2012-10-05 05:22:24 PDT
Created attachment 167313 [details] Try to fix the errors loading the favicon
WebKit Review Bot
Comment 4 2012-10-05 05:26:33 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 5 2012-10-05 08:26:06 PDT
Committed r130507: <http://trac.webkit.org/changeset/130507>
Note You need to log in before you can comment on or make changes to this bug.