Bug 98337

Summary: [chromium] New WeRenderingStats for compositor frames
Product: WebKit Reporter: Brian Anderson <brianderson>
Component: New BugsAssignee: Brian Anderson <brianderson>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, dglazkov, dtu, fishd, jamesr, nduca, reveman, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch jamesr: review-

Brian Anderson
Reported 2012-10-03 18:32:02 PDT
[chromium] New WeRenderingStats for CSyncs
Attachments
Patch (2.88 KB, patch)
2012-10-03 18:33 PDT, Brian Anderson 		no flags
DetailsFormatted DiffDiff
Patch (4.80 KB, patch)
2012-10-04 13:11 PDT, Brian Anderson 		no flags
DetailsFormatted DiffDiff
Patch (4.79 KB, patch)
2012-10-05 16:20 PDT, Brian Anderson 		no flags
DetailsFormatted DiffDiff
Patch (5.11 KB, patch)
2012-10-05 16:47 PDT, Brian Anderson 		no flags
DetailsFormatted DiffDiff
Patch (4.90 KB, patch)
2012-10-16 18:43 PDT, Brian Anderson 		jamesr: review-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brian Anderson
Comment 1 2012-10-03 18:33:04 PDT
Created attachment 167016 [details] Patch
WebKit Review Bot
Comment 2 2012-10-03 18:35:31 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Nat Duca
Comment 3 2012-10-03 18:40:30 PDT
+dtu
Brian Anderson
Comment 4 2012-10-04 13:11:41 PDT
Created attachment 167162 [details] Patch
Brian Anderson
Comment 5 2012-10-05 16:20:44 PDT
Created attachment 167407 [details] Patch
Brian Anderson
Comment 6 2012-10-05 16:47:20 PDT
Created attachment 167416 [details] Patch
Brian Anderson
Comment 7 2012-10-05 18:41:19 PDT
I need to get this patch in before I can get the chromium patch in. Can we go ahead and commit this?
Brian Anderson
Comment 8 2012-10-16 18:43:29 PDT
Created attachment 169068 [details] Patch
James Robinson
Comment 9 2012-10-16 18:47:29 PDT
Comment on attachment 169068 [details] Patch I don't think patching WebKit for this is needed - the produce and consumer of these stats are on the chromium side, WebKit isn't adding any value. If you need this quickly then I'd suggest patching the chromium side by adding a subclass of WebRenderingStats that has the values you want and then downcasting in src/webkit/compositor_bindings/WebLayerTreeViewImpl.cpp. If you aren't in a huge rush, once http://crbug.com/156175 gets resolved this'll be less ugly.
Brian Anderson
Comment 10 2012-10-22 15:31:33 PDT
Going with https://codereview.chromium.org/11189081 instead.
Note You need to log in before you can comment on or make changes to this bug.