Bug 98333

Summary: [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98310    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Adrian Perez
Reported 2012-10-03 17:35:58 PDT
[GTK] Enable inspector by default in GtkLauncher/MiniBrowser
Attachments
Patch (2.19 KB, patch)
2012-10-03 17:55 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2012-10-04 04:57 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2012-10-03 17:38:44 PDT
Both MiniBrowser and GtkLauncher are tools for testing, so in the end every time we want to test the inspector we have to manually enable enable the “developer extras” setting when using them. It would make sense to have this setting enabled by default.
Adrian Perez
Comment 2 2012-10-03 17:55:24 PDT
Created attachment 167011 [details] Patch
Alberto Garcia
Comment 3 2012-10-04 04:23:22 PDT
> Tools/GtkLauncher/main.c:492 > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); You don't really need the cast here, g_object_set() receives a gpointer. Otherwise it looks fine :)
Xan Lopez
Comment 4 2012-10-04 04:34:00 PDT
Comment on attachment 167011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review > Tools/GtkLauncher/main.c:492 > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise I guess we should try to use the same when thing possible. r- because you need cq to land this, so please re-upload.
Adrian Perez
Comment 5 2012-10-04 04:45:17 PDT
(In reply to comment #4) > (From update of attachment 167011 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review > > > Tools/GtkLauncher/main.c:492 > > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); > > Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise I guess we should try to use the same when thing possible. WK1 API exposes only the GObject properties, the WK2 API has also the convenience setter/getter functions, so it seemed natural to use them. Would it be better to use also g_object_set when using the WK2 API? (IMHO using the setter is easier on the eyes). > r- because you need cq to land this, so please re-upload. Will do.
Adrian Perez
Comment 6 2012-10-04 04:57:38 PDT
Created attachment 167077 [details] Patch Updated patch, and requested commit-queue flag for it
Xan Lopez
Comment 7 2012-10-04 04:59:03 PDT
Comment on attachment 167077 [details] Patch Looks good!
WebKit Review Bot
Comment 8 2012-10-04 05:23:55 PDT
Comment on attachment 167077 [details] Patch Clearing flags on attachment: 167077 Committed r130386: <http://trac.webkit.org/changeset/130386>
WebKit Review Bot
Comment 9 2012-10-04 05:23:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.