Bug 98332

Summary: Removed the assumption that "final" objects have a fixed number of inline slots
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Geoffrey Garen
Reported 2012-10-03 17:24:30 PDT
Removed the assumption that "final" objects have a fixed number of inline slots
Attachments
Patch (40.20 KB, patch)
2012-10-03 17:53 PDT, Geoffrey Garen 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-10-03 17:53:57 PDT
Created attachment 167010 [details] Patch
Filip Pizlo
Comment 2 2012-10-03 17:57:17 PDT
Comment on attachment 167010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167010&action=review r=me > Source/JavaScriptCore/runtime/Structure.h:429 > + uint32_t m_inlineCapacity; Any chance we could make this uint8_t and squeeze it in somewhere? Your call.
Geoffrey Garen
Comment 3 2012-10-03 20:54:53 PDT
> Any chance we could make this uint8_t and squeeze it in somewhere? It appears that we can do some squishing by making this a uint8_t and shrinking the number of bits we use for attributes. I'll do the uint8_t thing in this patch, and shrinking the attributes in another, since there might be gotchas there.
Geoffrey Garen
Comment 4 2012-10-03 21:09:04 PDT
<http://trac.webkit.org/changeset/130359>
Geoffrey Garen
Comment 5 2012-10-03 21:12:38 PDT
<http://trac.webkit.org/changeset/130360>
Geoffrey Garen
Comment 6 2012-10-03 21:51:38 PDT
<http://trac.webkit.org/changeset/130361>
Note You need to log in before you can comment on or make changes to this bug.