Bug 98313 – ScrollingStateNode should keep a Vector of children instead of child pointers

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Beth Dakin]

ScrollingStateNode was added with https://bugs.webkit.org/show_bug.cgi?id=97365 We can vastly simplify that class by making each node have a Vector of children instead of of keeping child and sibling pointers.

[Beth Dakin]

Created attachment 166983 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 166983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166983&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore):

(WebCore):

> Source/WebCore/page/scrolling/ScrollingStateNode.h:81
> +    Vector<OwnPtr<ScrollingStateNode> > m_children;

Maybe use a Vector* since many nodes won't have children.

[Beth Dakin]

(In reply to comment #2)
> (From update of attachment 166983 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166983&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        (WebCore):
> 
> (WebCore):
> 
> > Source/WebCore/page/scrolling/ScrollingStateNode.h:81
> > +    Vector<OwnPtr<ScrollingStateNode> > m_children;
> 
> Maybe use a Vector* since many nodes won't have children.

Thanks Simon! I took care of both. http://trac.webkit.org/changeset/130342

[Rafael Brandao]

I believe this bug is fixed. Closing it.