Summary: | Parsing of media queries: 'all and(color)' should be invalid | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Sapin <simon-webkit> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||
Severity: | Normal | CC: | bfulgham, karl+webkit, simon-webkit | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://dabblet.com/gist/3829879 | ||||||
Attachments: |
|
Description
Simon Sapin
2012-10-03 14:36:16 PDT
If the User-Agent string is to be trusted, my Chromium build uses WebKit 537.4. Created attachment 166964 [details]
Require some whitespace after 'and' in a media query.
Sorry, untested patch. (I have yet to manage a build.) Other files might need to be changed, but this looks like the right area of the code.
The patch is wrong, white space is not actually required. This is valid: "all and/*wooo!*/(color)". http://lists.w3.org/Archives/Public/www-style/2012Oct/0099.html David Baron in https://bugzilla.mozilla.org/show_bug.cgi?id=1031966#c7 > The CSSWG has had multiple extensive discussions > of this issue; in the last one we actually resolved > to require the whitespace (i.e., disallow "and/**/("): > > http://lists.w3.org/Archives/Public/www-style/2013Jul/0082.html And in > MQ4 says, in http://dev.w3.org/csswg/mediaqueries/#mq-syntax : > > Whitespace must be present between a ')' character and > a not, and, or or keyword, and between a not, and, or > or keyword and a '(' character. The parsing of "and(" fails in Opera (blink), IE11, Chrome, and Firefox. Safari (to the best of my knowledge is the only one to parse it). Related to this bug https://bugs.webkit.org/show_bug.cgi?id=45017 Safari, Chrome, and Firefox all agree on rendering for this test case. I don't believe there is any remaining compatibility issue. |