Bug 98274

Summary: Make dfg-cross-global-object-inline-new-array-with-elements less flaky
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: NEW    
Severity: Normal CC: eric, fpizlo, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98192    
Attachments:
Description Flags
Patch eric: review+

Erik Arvidsson
Reported 2012-10-03 09:10:23 PDT
Make dfg-cross-global-object-inline-new-array-with-elements less flaky
Attachments
Patch (2.76 KB, patch)
2012-10-03 09:12 PDT, Erik Arvidsson 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-10-03 09:12:10 PDT
Created attachment 166908 [details] Patch
Ojan Vafai
Comment 2 2012-10-03 09:21:05 PDT
Thanks! It looks like there are 5 dfg-cross-global-object-inline tests here that all use the same pattern and are all flaky. Mind fixing them all at once? The setTimeout looks unnecessary, but just to be sure I'm CC'ing the original author. On a side note, this is why I think we need to instrument waitUntilDone/notifyDone to just do this jsTestIsAsync/finishJSTest behavior automatically. People shouldn't need to learn the js-test-pre way of doing the same thing.
Erik Arvidsson
Comment 3 2012-10-03 09:31:35 PDT
(In reply to comment #2) > On a side note, this is why I think we need to instrument waitUntilDone/notifyDone to just do this jsTestIsAsync/finishJSTest behavior automatically. People shouldn't need to learn the js-test-pre way of doing the same thing. I'm all for doing that. I'll make that change and see who screams.
Eric Seidel (no email)
Comment 4 2012-10-08 16:10:49 PDT
Comment on attachment 166908 [details] Patch SGTM.
Note You need to log in before you can comment on or make changes to this bug.