Bug 9827

Summary: Support CSS3 content:
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: CSSAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.w3.org/TR/css3-content/#inserting3
Attachments:
Description Flags
First patch
none
newer
none
again! mjs: review+

Beth Dakin
Reported 2006-07-10 01:43:59 PDT
We should support the CSS3 content property.
Attachments
First patch (19.10 KB, patch)
2006-07-10 01:47 PDT, Beth Dakin
no flags
newer (5.75 KB, patch)
2006-07-10 04:05 PDT, Beth Dakin
no flags
again! (13.67 KB, patch)
2006-07-10 04:29 PDT, Beth Dakin
mjs: review+
Beth Dakin
Comment 1 2006-07-10 01:47:06 PDT
Created attachment 9332 [details] First patch So here is a patch. I am not sure it's right. I am not sure I am even interpreting the spec correctly. And even if I am, this patch ignores text (there will need to be a follow-up bug about that). Also, I am not sure that peppering all of the createRenderer() functions with the check for contentData() is the most elegant implementation. Feedback desired!
Beth Dakin
Comment 2 2006-07-10 04:05:42 PDT
Created attachment 9336 [details] newer Maciej and I talked about this a bunch over iChat. Here is a revised patch based on our conversation.
Beth Dakin
Comment 3 2006-07-10 04:29:25 PDT
Created attachment 9337 [details] again! A little more tweaking, some changelogs, and some layout tests.
Maciej Stachowiak
Comment 4 2006-07-10 04:30:34 PDT
Comment on attachment 9337 [details] again! r=me
David Kilzer (:ddkilzer)
Comment 5 2006-07-10 05:02:28 PDT
Beth committed revision 15299.
Note You need to log in before you can comment on or make changes to this bug.