Bug 98246

Summary: Web Inspector: [Styles] Unable to edit properties in broken stylesheets
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: 7raivis, apavlov, bweinstein, cmarcelo, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 98520    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch vsevik: review+

Alexander Pavlov (apavlov)
Reported 2012-10-03 02:42:23 PDT
For some broken stylesheets, CSSParser produces source data inconsistent with the resulting CSSOM.
Attachments
Patch (17.23 KB, patch)
2012-10-03 03:10 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (22.64 KB, patch)
2012-10-04 05:50 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (21.50 KB, patch)
2012-10-05 03:39 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (18.64 KB, patch)
2012-10-05 06:20 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (19.51 KB, patch)
2012-10-05 07:43 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (17.46 KB, patch)
2012-10-05 08:20 PDT, Alexander Pavlov (apavlov) 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-10-03 03:10:40 PDT
Created attachment 166843 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-10-04 05:50:32 PDT
Created attachment 167084 [details] Patch
Vsevolod Vlasov
Comment 3 2012-10-05 03:12:32 PDT
Comment on attachment 167084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167084&action=review > Source/WebCore/css/CSSParser.cpp:10328 > + if (!m_currentRuleData->isBlockRule() && m_currentRuleData->type != CSSRuleSourceData::IMPORT_RULE) I don't think this condition is ever true.
Alexander Pavlov (apavlov)
Comment 4 2012-10-05 03:39:04 PDT
Created attachment 167301 [details] Patch
Alexander Pavlov (apavlov)
Comment 5 2012-10-05 06:20:09 PDT
Created attachment 167317 [details] Patch
Alexander Pavlov (apavlov)
Comment 6 2012-10-05 07:43:14 PDT
Created attachment 167327 [details] Patch
Vsevolod Vlasov
Comment 7 2012-10-05 08:16:14 PDT
Comment on attachment 167327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167327&action=review > Source/WebCore/css/CSSParser.cpp:10300 > + m_currentRuleData.clear(); Redundant > Source/WebCore/css/CSSParser.cpp:10302 > + m_currentRuleData = CSSRuleSourceData::create(ruleType); Let's just add m_currentRuleData = data; above. > Source/WebCore/css/CSSParser.cpp:-10382 > - SourceRange& topRuleBodyRange = m_currentRuleDataStack->last()->ruleBodyRange; Looks like a separate change.
Vsevolod Vlasov
Comment 8 2012-10-05 08:16:47 PDT
Comment on attachment 167327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167327&action=review > Source/WebCore/css/CSSParser.cpp:9929 > + popRuleData(); This should be put into separate patch, you should also fix some similar issues with other types of rules.
Alexander Pavlov (apavlov)
Comment 9 2012-10-05 08:20:27 PDT
Created attachment 167330 [details] Patch
Alexander Pavlov (apavlov)
Comment 10 2012-10-05 09:00:41 PDT
Committed r130511: <http://trac.webkit.org/changeset/130511>
Binyamin
Comment 11 2012-10-06 10:42:06 PDT
Related Chrome bug http://code.google.com/p/chromium/issues/detail?id=152636
Note You need to log in before you can comment on or make changes to this bug.