Refactoring: DateTimeEditBuilder had better hold LayoutParameters

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

Refactoring: DateTimeEditBuilder had better hold LayoutParameters

[Kent Tamura]

Created attachment 166803 [details]
Patch

[Kentaro Hara]

Comment on attachment 166803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166803&action=review

Looks OK.

> Source/WebCore/ChangeLog:9
> +        constructor. This change improves code size and runtime cost.

This change increases the size of a DateTimeEditBuilder object. I don't think this is a big deal, but please just keep it in mind:

Before:
const StepRange m_stepRange;
Localizer& m_localizer;
const String m_placeholderForDay;
const String m_placeholderForMonth;
const String m_placeholderForYear;

After:
String dateTimeFormat;
String fallbackDateTimeFormat;
Localizer& localizer;
const StepRange stepRange;
String placeholderForMonth;
String placeholderForYear;

> Source/WebCore/ChangeLog:19
> +        Add m_parmaeters.

Typo: m_parmaeters

[Kent Tamura]

Comment on attachment 166803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166803&action=review

>> Source/WebCore/ChangeLog:9
>> +        constructor. This change improves code size and runtime cost.
> 
> This change increases the size of a DateTimeEditBuilder object. I don't think this is a big deal, but please just keep it in mind:
> 
> Before:
> const StepRange m_stepRange;
> Localizer& m_localizer;
> const String m_placeholderForDay;
> const String m_placeholderForMonth;
> const String m_placeholderForYear;
> 
> After:
> String dateTimeFormat;
> String fallbackDateTimeFormat;
> Localizer& localizer;
> const StepRange stepRange;
> String placeholderForMonth;
> String placeholderForYear;

No. m_parameters is a const reference, which is equivalent to one pointer internally.

>> Source/WebCore/ChangeLog:19
>> +        Add m_parmaeters.
> 
> Typo: m_parmaeters

oops. will fix.

[Kentaro Hara]

(In reply to comment #3)
> (From update of attachment 166803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166803&action=review
> 
> No. m_parameters is a const reference, which is equivalent to one pointer internally.

Ah, got it.

[Kent Tamura]

Committed r130246: <http://trac.webkit.org/changeset/130246>