| Summary: | Shrink ElementRareData by moving bool flags to NodeRareData. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2012-10-02 20:19:03 PDT
Created attachment 166800 [details]
Patch
Comment on attachment 166800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review r=me > Source/WebCore/ChangeLog:9 > + Move all bool flags from ElementRareData to the bitfield in its base class NodeRareData. > + This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups. Would be nice to tell why this is worth doing. Created attachment 166867 [details]
Potch for londong
Comment on attachment 166867 [details] Potch for londong Clearing flags on attachment: 166867 Committed r130278: <http://trac.webkit.org/changeset/130278> All reviewed patches have been landed. Closing bug. Comment on attachment 166800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review >> Source/WebCore/ChangeLog:9 >> + This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups. > > Would be nice to tell why this is worth doing. Do we want a rare data compile time size assertion so people notice when they bloat it? |