Bug 98195

Summary: Remove the last bits of MSYS support from webkitperl.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2012-10-02 13:39:18 PDT
Remove the last bits of MSYS support from webkitperl.
Attachments
Patch (3.11 KB, patch)
2012-10-02 13:40 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-10-02 13:40:37 PDT
Created attachment 166742 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-02 13:45:48 PDT
Comment on attachment 166742 [details] Patch LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :)
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-10-02 13:57:00 PDT
(In reply to comment #2) > (From update of attachment 166742 [details]) > LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :) Hmm, MinGW support in Source/ consists mainly in compiler ifdefs; killing that would probably make at least Dirk unhappy.
WebKit Review Bot
Comment 4 2012-10-02 14:09:01 PDT
Comment on attachment 166742 [details] Patch Clearing flags on attachment: 166742 Committed r130210: <http://trac.webkit.org/changeset/130210>
WebKit Review Bot
Comment 5 2012-10-02 14:09:04 PDT
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 6 2012-10-02 14:21:02 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 166742 [details] [details]) > > LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :) > > Hmm, MinGW support in Source/ consists mainly in compiler ifdefs; killing that would probably make at least Dirk unhappy. Dirk == me? I only do win32 builds.
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-10-02 14:29:50 PDT
(In reply to comment #6) > Dirk == me? Yep. > I only do win32 builds. Oh, I thought you meant you also built with mingw in https://bugs.webkit.org/show_bug.cgi?id=98183#c6
Dirk Pranke
Comment 8 2012-10-02 15:45:30 PDT
(In reply to comment #7) > (In reply to comment #6) > > Dirk == me? > Yep. > > > I only do win32 builds. > Oh, I thought you meant you also built with mingw in https://bugs.webkit.org/show_bug.cgi?id=98183#c6 No, I meant that I often run the tests from under a mingw/msysgit bash environment. However, I think I've mostly used the stock win32 python in this case.
Note You need to log in before you can comment on or make changes to this bug.