Bug 98166

Summary:

[chromium] Pixel tests with a device/page scale factor of 2 no longer need to be marked as failing

Product:

WebKit

Reporter:

Terry Anderson <tdanderson>

Component:

Tools / Tests

Assignee:

Terry Anderson <tdanderson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alexst, rjkroege

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

98526

Bug Blocks:

Attachments:

Description	Flags
Over-hinted text in a chromium-linux pixel test	none
Patch	none
Patch	tdanderson: review-

Terry Anderson

Reported 2012-10-02 09:08:25 PDT

Created attachment 166694 [details] Over-hinted text in a chromium-linux pixel test The tests added to TestExpectations in https://bugs.webkit.org/show_bug.cgi?id=96137 will need new image baselines for Linux. This will require a change in the level of hinting used when rendering fonts in DRT. In Source/WebKit/chromium/src/linux/WebFontInfo.cpp::renderStyleForStrike(), |hintStyle| is set to 3 (full hinting) by chromium DRT but is set to 1 (slight hinting) by chromium itself. Slight hinting should be used in both cases otherwise we will end up with baselines looking terrible (see attached).

Attachments
Over-hinted text in a chromium-linux pixel test (22.10 KB, image/png) 2012-10-02 09:08 PDT, Terry Anderson	no flags	Details
Patch (4.21 KB, patch) 2012-10-02 09:11 PDT, Terry Anderson	no flags	Details Formatted Diff Diff
Patch (4.24 KB, patch) 2012-10-10 10:57 PDT, Terry Anderson	tdanderson: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Terry Anderson

Comment 1 2012-10-02 09:11:52 PDT

Created attachment 166696 [details] Patch

Terry Anderson

Comment 2 2012-10-02 09:12:58 PDT

Comment on attachment 166696 [details] Patch I am uploading this only to confirm that the EWS bots give the same pixel output for chromium-linux that I am seeing locally.

Terry Anderson

Comment 3 2012-10-10 10:57:08 PDT

Created attachment 168035 [details] Patch

Terry Anderson

Comment 4 2012-10-10 15:47:42 PDT

Due to bug 98526, new baselines are no longer needed since the font hinting is only changed when building for chromeOS. The tests were removed from TestExpectations in http://trac.webkit.org/changeset/130933

Note You need to log in before you can comment on or make changes to this bug.