Bug 98124

Summary: Remove anonymous namespace from StyleBuilder.cpp for better debugging experience
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: CSSAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, ap, bweinstein, cmarcelo, darin, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2012-10-02 01:03:24 PDT
As Alexey and Darin pointed out in wkbug.com/98028 we should avoid anonymous namespaces as they complicate debugging and break some IDE's code assistance. Original problem is already resolved by picking more specific name that doesn't collide with other type names and the code can continue to reside in the WebCore namespace.
Attachments
Patch (1.54 KB, patch)
2012-10-02 01:14 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-10-02 01:14:52 PDT
Created attachment 166638 [details] Patch
WebKit Review Bot
Comment 2 2012-10-02 02:29:06 PDT
Comment on attachment 166638 [details] Patch Clearing flags on attachment: 166638 Committed r130142: <http://trac.webkit.org/changeset/130142>
WebKit Review Bot
Comment 3 2012-10-02 02:29:10 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2012-10-02 13:15:13 PDT
Thank you!
Note You need to log in before you can comment on or make changes to this bug.