Bug 98105

Summary: [CMAKE] Add GLOBAL_FASTMALLOC_NEW in cmakeconfig.h.cmake
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: New BugsAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED WONTFIX    
Severity: Normal CC: eric, gyuyoung.kim, rakuco, ryuan.choi, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jinwoo Song
Reported 2012-10-01 19:53:22 PDT
GLOBAL_FASTMALLOC_NEW feature is not included in cmakeconfig.h.cmake.
Attachments
Patch (2.26 KB, patch)
2012-10-03 22:26 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-10-03 22:26:32 PDT
Created attachment 167031 [details] Patch
Ryuan Choi
Comment 2 2012-10-03 22:33:30 PDT
Comment on attachment 167031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167031&action=review > ChangeLog:3 > + [CMAKE] Add GLOBAL_FASTMALLOC_NEW in cmakeconfig.h.cmake Other ports looks define it in Platform.h. Should we need to enable/disable it in compile time?
Zoltan Horvath
Comment 3 2012-10-08 16:33:26 PDT
Hi there, It's enabled by default in Platform.h. I don't see how lead it ambiguity. Furthermore, this macro _should not_ be considered as a feature. (In reply to comment #2) > (From update of attachment 167031 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167031&action=review > > > ChangeLog:3 > > + [CMAKE] Add GLOBAL_FASTMALLOC_NEW in cmakeconfig.h.cmake > > Other ports looks define it in Platform.h. > > Should we need to enable/disable it in compile time? You shouldn't change this macro until you don't have problems with customizing global memory operators on your platform. I don't see any benefit from this change, so I would r- this patch, but I'm not a reviewer yet.
Jinwoo Song
Comment 4 2012-10-08 18:42:24 PDT
(In reply to comment #3) > Hi there, > > It's enabled by default in Platform.h. I don't see how lead it ambiguity. Furthermore, this macro _should not_ be considered as a feature. > > (In reply to comment #2) > > > (From update of attachment 167031 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=167031&action=review > > > > > ChangeLog:3 > > > + [CMAKE] Add GLOBAL_FASTMALLOC_NEW in cmakeconfig.h.cmake > > > > Other ports looks define it in Platform.h. > > > > Should we need to enable/disable it in compile time? > > You shouldn't change this macro until you don't have problems with customizing global memory operators on your platform. > > I don't see any benefit from this change, so I would r- this patch, but I'm not a reviewer yet. Okay, I got your point and I'll not change it. Thanks for good feedback. :)
Note You need to log in before you can comment on or make changes to this bug.