Bug 98103

Summary: Move tests for calendar picker to platform/chromium/fast/forms/calendar-picker/
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, keishi, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2 yutak: review+

Kent Tamura
Reported 2012-10-01 18:46:02 PDT
Move tests for calendar picker to fast/forms/calendar-picker/ because of ease of skipping and we're going to support non-date types in the calendar picker.
Attachments
Patch (184.23 KB, patch)
2012-10-16 02:11 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (185.06 KB, patch)
2012-10-16 03:06 PDT, Kent Tamura 		yutak: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-16 00:33:46 PDT
Also, we're not sure the calendar picker code will be used on other platforms.
Kent Tamura
Comment 2 2012-10-16 02:11:25 PDT
Created attachment 168895 [details] Patch
WebKit Review Bot
Comment 3 2012-10-16 03:01:58 PDT
Comment on attachment 168895 [details] Patch Attachment 168895 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14387100 New failing tests: platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html
Kent Tamura
Comment 4 2012-10-16 03:06:04 PDT
Created attachment 168906 [details] Patch 2 Fix page-poup-adjust-rect.html
Yuta Kitamura
Comment 5 2012-10-16 08:31:36 PDT
Comment on attachment 168906 [details] Patch 2 Rubber-stamped. I see image results are not correctly shown in the code review screen (some say "Image lacks a checksum"). I'm not sure why they are shown like this, but please make sure the images are correctly moved before landing.
Kent Tamura
Comment 6 2012-10-16 18:18:30 PDT
Committed r131538: <http://trac.webkit.org/changeset/131538>
Note You need to log in before you can comment on or make changes to this bug.