Bug 98091

Summary: IndexedDB: Don't wedge if page reloads with pending upgradeneeded
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description David Grogan 2012-10-01 16:44:39 PDT 
IndexedDB: Don't wedge if page reloads with pending upgradeneeded
Comment 1 David Grogan 2012-10-01 16:51:33 PDT 
Created attachment 166571 [details]
Patch
Comment 2 David Grogan 2012-10-01 16:53:40 PDT 
Created attachment 166572 [details]
Patch
Comment 3 David Grogan 2012-10-01 18:01:41 PDT 
Created attachment 166582 [details]
Patch
Comment 4 David Grogan 2012-10-01 18:03:33 PDT 
Josh, could you look at this?
Comment 5 David Grogan 2012-10-01 18:13:15 PDT 
Created attachment 166586 [details]
Patch
Comment 6 Joshua Bell 2012-10-01 18:22:24 PDT 
Lgtm
Comment 7 David Grogan 2012-10-01 18:45:13 PDT 
Tony, could you review this?
Comment 8 Tony Chang 2012-10-02 09:53:30 PDT 
Comment on attachment 166586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166586&action=review

> LayoutTests/storage/indexeddb/resources/dont-wedge.js:26
> +    else
> +        debug("In content_shell this deleteDatabase request is blocked temporarily");

Nit: I would make this comment more general. Rather than name content_shell, maybe say in a multiprocess implementation, this deleteDatabase request can be blocked temporarily.  Someone may want to run this test in another browser or in a few years, we may be using something other than content_shell.
Comment 9 David Grogan 2012-10-02 11:24:49 PDT 
Comment on attachment 166586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166586&action=review

>> LayoutTests/storage/indexeddb/resources/dont-wedge.js:26
>> +        debug("In content_shell this deleteDatabase request is blocked temporarily");
> 
> Nit: I would make this comment more general. Rather than name content_shell, maybe say in a multiprocess implementation, this deleteDatabase request can be blocked temporarily.  Someone may want to run this test in another browser or in a few years, we may be using something other than content_shell.

SG, thanks for the review.
Comment 10 David Grogan 2012-10-02 11:43:26 PDT 
Created attachment 166723 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-10-02 13:09:04 PDT 
Comment on attachment 166723 [details]
Patch for landing

Clearing flags on attachment: 166723

Committed r130199: <http://trac.webkit.org/changeset/130199>
Comment 12 WebKit Review Bot 2012-10-02 13:09:07 PDT 
All reviewed patches have been landed.  Closing bug.