Bug 98085

Summary: IndexedDB: remove autogenerated objectStore/index id code
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, peter+ews, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97834    
Bug Blocks: 98682    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alec Flett 2012-10-01 15:48:16 PDT 
After we land bug 97834, we'll need to remove support for autogenerated objectStore  and index database ids.
Comment 1 Alec Flett 2012-10-08 13:22:44 PDT 
Created attachment 167596 [details]
Patch
Comment 2 Alec Flett 2012-10-08 13:23:20 PDT 
jsbell@ - quick once-over? mostly code removal.
Comment 3 Alec Flett 2012-10-08 13:34:39 PDT 
jsbell@ - wait ignore that there were a few more things I just figured out I could remove.
Comment 4 WebKit Review Bot 2012-10-08 14:07:11 PDT 
Comment on attachment 167596 [details]
Patch

Attachment 167596 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14197024
Comment 5 Joshua Bell 2012-10-08 14:13:12 PDT 
Comment on attachment 167596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167596&action=review

lgtm, one nit.

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:-628
> -    ASSERT(maxIndexIds.size() == ids.size());

Why is this being removed?
Comment 6 Peter Beverloo (cr-android ews) 2012-10-08 14:21:05 PDT 
Comment on attachment 167596 [details]
Patch

Attachment 167596 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14228336
Comment 7 Alec Flett 2012-10-08 14:29:29 PDT 
Created attachment 167610 [details]
Patch
Comment 8 WebKit Review Bot 2012-10-08 14:32:45 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 9 Alec Flett 2012-10-08 14:33:32 PDT 
ok this is ready - turns out the chromium side wasn't calling into the old API, thus could be removed in one shot. 

jsbell@ - ready for review. even more code/scaffolding removal than the previous patch.
Comment 10 Joshua Bell 2012-10-08 14:42:04 PDT 
Comment on attachment 167610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167610&action=review

Still lgtm, w/ nits.

> Source/WebCore/ChangeLog:-1555
> -

Accidental whitespace removal?

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:-628
> -    ASSERT(maxIndexIds.size() == ids.size());

Still want this assert?
Comment 11 Alec Flett 2012-10-08 14:46:59 PDT 
Created attachment 167619 [details]
Patch
Comment 12 Alec Flett 2012-10-08 14:47:54 PDT 
tony@ - r?

abarth@ - r? for chromium glue (just code removal)
Comment 13 WebKit Review Bot 2012-10-08 18:17:55 PDT 
Comment on attachment 167619 [details]
Patch

Clearing flags on attachment: 167619

Committed r130708: <http://trac.webkit.org/changeset/130708>
Comment 14 WebKit Review Bot 2012-10-08 18:17:59 PDT 
All reviewed patches have been landed.  Closing bug.