Summary: | REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P1 | ||||||||||
Version: | 420+ | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Attachments: |
|
Description
mitz
2006-07-09 11:02:11 PDT
Created attachment 9299 [details]
Test case
Created attachment 9300 [details]
Patch with manual test and changelog
Comment on attachment 9300 [details]
Patch with manual test and changelog
Will this extra check have a measurable performance impact?
If not, then r=me, but how can we be sure?
Comment on attachment 9300 [details]
Patch with manual test and changelog
Going to play it safe performance-wise and move the check into the complex path where it matters.
Created attachment 9341 [details]
Patch
Move the empty run check down into floatWidthForComplexText()
Comment on attachment 9341 [details]
Patch
r=me
Even better if there was a comment explaining that this is not just an optimization, but required for correct results, but the layout test should suffice.
Committed revision 15305. |