Bug 98061

Summary: Disable hinting when webkit-font-smoothing:antialiased is used on Mac.
Product: WebKit Reporter: bungeman
Component: PlatformAssignee: bungeman
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, reed, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

bungeman
Reported 2012-10-01 12:53:54 PDT
Disable hinting when webkit-font-smoothing:antialiased is used on Mac.
Attachments
Patch (1.98 KB, patch)
2012-10-01 13:02 PDT, bungeman 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2012-10-05 13:17 PDT, bungeman 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2012-10-06 09:14 PDT, bungeman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
bungeman
Comment 1 2012-10-01 13:02:56 PDT
Created attachment 166529 [details] Patch
Mike Reed
Comment 2 2012-10-02 07:55:12 PDT
are we putting this on hold, pending the search for other mechanisms that are more explicit?
bungeman
Comment 3 2012-10-05 13:17:48 PDT
Created attachment 167371 [details] Patch
bungeman
Comment 4 2012-10-05 13:33:38 PDT
USE(SKIA_ON_MAC_CHROMIUM) is currently always true when FontSkia.cpp is included. However, this documents for the future merging of the various 'Font' implementations that this is Mac specific. Requesting re-evaluation now that the Skia changes have settled down.
Mike Reed
Comment 5 2012-10-05 13:48:28 PDT
works for me
Stephen White
Comment 6 2012-10-05 14:18:37 PDT
Comment on attachment 167371 [details] Patch I think we prefer #if PLATFORM(CHROMIUM) && OS(DARWIN) in platform/graphics/skia. SKIA_ON_MAC_CHROMIUM only seems to be used in cross-platform code, and should be replaced with the above now anyway.
Build Bot
Comment 7 2012-10-05 14:47:13 PDT
Comment on attachment 167371 [details] Patch Attachment 167371 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14183532 New failing tests: http/tests/workers/terminate-during-sync-operation.html
bungeman
Comment 8 2012-10-06 09:14:54 PDT
Created attachment 167457 [details] Patch
bungeman
Comment 9 2012-10-06 09:34:23 PDT
Changed test to '#if OS(DARWIN)' since this is the desired behavior, Chromium or not (though Chromium is the only one currently using this file). It would be nice if the test could be more like '#if SKIA_FONT_HOST(CORE_GRAPHICS)' since that's what we're really getting at here. The webkit-font-smoothing css property is just exposing a CoreGraphics API. It just happens to be that currently 'OS(DARWIN)' will have the same value as the ephemeral 'SKIA_FONT_HOST(CORE_GRAPHICS)'. That's why I proposed using SKIA_ON_MAC_CHROMIUM, as it seemed closer to 'SKIA_FONT_HOST(CORE_GRAPHICS)'. The test '#if OS(DARWIN)' is fine for now, but I have modified the comment to clarify the situation.
Stephen White
Comment 10 2012-10-09 13:00:10 PDT
Comment on attachment 167457 [details] Patch OK. r=me
WebKit Review Bot
Comment 11 2012-10-09 13:06:18 PDT
Comment on attachment 167457 [details] Patch Clearing flags on attachment: 167457 Committed r130800: <http://trac.webkit.org/changeset/130800>
WebKit Review Bot
Comment 12 2012-10-09 13:06:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.