Bug 98053 – Web Inspector: move completions calculation into RuntimeModel (part 1)

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

- moves current execution context state into runtime model
- moves completionsForTextPrompt and its private helpers into runtime model
- makes text prompt use generic expression stop characters by default

[Pavel Feldman]

Created attachment 166512 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 166512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166512&action=review

> Source/WebCore/inspector/front-end/RuntimeModel.js:167
> +    completionsForTextPrompt: function(textPrompt, wordRange, force, completionsReadyCallback)

Can we get rid of dependency on TextPrompt here?

> Source/WebCore/inspector/front-end/RuntimeModel.js:170
> +        var expressionRange = wordRange.startContainer.rangeOfWord(wordRange.startOffset, " =:[({;,!+-*/&|^<>", textPrompt.proxyElement, "backward");

Can you extract constant for " =:[({;,!+-*/&|^<>" and reuse it in TextPrompt?

[Pavel Feldman]

> Can you extract constant for " =:[({;,!+-*/&|^<>" and reuse it in TextPrompt?

I am not sure why (and whether they should) correlate. I'll need to further refactor it. TextPrompt code is a mess.

[Pavel Feldman]

Committed r130119: <http://trac.webkit.org/changeset/130119>