Bug 98030

Summary:

Build fails with --gtk

Product:

WebKit

Reporter:

Ramkumar Ramachandra <artagnon>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Critical

CC:

artagnon, bburg, haraken, mrobinson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	haraken: review-
Patch	pnormand: review-

Ramkumar Ramachandra

Reported 2012-10-01 07:26:20 PDT

Build fails with --gtk

Attachments
Patch (114.39 KB, patch) 2012-10-01 07:29 PDT, Ramkumar Ramachandra	haraken: review-	Details Formatted Diff Diff
Patch (1.38 KB, patch) 2012-10-01 07:36 PDT, Ramkumar Ramachandra	pnormand: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ramkumar Ramachandra

Comment 1 2012-10-01 07:29:20 PDT

Created attachment 166474 [details] Patch

WebKit Review Bot

Comment 2 2012-10-01 07:33:37 PDT

Attachment 166474 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'configure.ac']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ramkumar Ramachandra

Comment 3 2012-10-01 07:36:43 PDT

Created attachment 166475 [details] Patch

Kentaro Hara

Comment 4 2012-10-01 09:04:47 PDT

Comment on attachment 166474 [details] Patch r-ing due to the wrong ChangeLog. Please set r? on the latest patch you uploaded:)

Ramkumar Ramachandra

Comment 5 2012-10-01 09:13:21 PDT

(In reply to comment #4) > (From update of attachment 166474 [details]) > r-ing due to the wrong ChangeLog. Please set r? on the latest patch you uploaded:) Yeah, sorry about that. I couldn't figure out how to use webkit-patch properly, so I attached the second patch by hand.

Ramkumar Ramachandra

Comment 6 2012-10-03 08:01:45 PDT

Has any progress been made on this?

Kentaro Hara

Comment 7 2012-10-03 08:07:39 PDT

mrobinson: could you take a look?

Martin Robinson

Comment 8 2012-10-03 08:47:53 PDT

Comment on attachment 166475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166475&action=review > configure.ac:1082 > +AM_CONDITIONAL([ENABLE_GTK_DOC],[test "$enable_gtk_doc" = "yes"]) I'm not sure why this is necessary. This should be activated by GTK_DOC_CHECK from Source/autotools/gtk-doc.m4.

Ramkumar Ramachandra

Comment 9 2012-10-04 09:31:46 PDT

Why doesn't it build for me without it then? What am I doing wrong?

Martin Robinson

Comment 10 2012-10-04 09:46:00 PDT

Perhaps you are missing the gtkdoc tools?

Philippe Normand

Comment 11 2013-04-12 12:23:00 PDT

Comment on attachment 166475 [details] Patch r- as per Martin's comments. Also configure.ac was refactored so this patch won't apply anymore.

Blaze Burg

Comment 12 2014-03-25 15:15:03 PDT

Closing invalid as the build system for this patch doesn't exist.

Note You need to log in before you can comment on or make changes to this bug.