Summary: | computedstyle perspective-origin is based on the wrong boundingbox | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jussi Kukkonen (jku) <jussi.kukkonen> | ||||||||
Component: | CSS | Assignee: | Jussi Kukkonen (jku) <jussi.kukkonen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, cmarcelo, dino, macpherson, menard, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jussi Kukkonen (jku)
2012-10-01 06:42:49 PDT
Created attachment 166647 [details]
Patch
Thanks Simon, that test actually looks like a better place to test this as well
Hm, looks like I've missed transforms/3d/point-mapping/ tests at least. Will check and update those (In reply to comment #3) > Hm, looks like I've missed transforms/3d/point-mapping/ tests at least. So chromium-ews was flaky for a cycle in transforms/3d/point-mapping/. Actually those tests don't really seem to check the computedStyle (and this bug only covers that). As far as I can see all the existing tests that test perspective-origin via computedStyle happen to not use borders or pass in px values so don't hit the bug. Just to be double sure I checked the transforms/3d/point-mapping/ results on GTK -- they are identical to results before patch. I think this is good to go. Was it only wrong for computed style, but correct for rendering? If so, the title of this bug, and the Changelog need to make this clearer. Yes, that is correct: rendering is unchanged (and correct as far as I can tell), but computedstyle is wrong. I'll update the changelog. Created attachment 166741 [details]
Patch
Comment on attachment 166741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166741&action=review > Source/WebCore/ChangeLog:3 > + getComputedStyle perspective-origin is based on the wrong boundingbox "bounding box" Created attachment 166826 [details]
Patch
Comment on attachment 166826 [details] Patch Clearing flags on attachment: 166826 Committed r130277: <http://trac.webkit.org/changeset/130277> All reviewed patches have been landed. Closing bug. |