Bug 98015

Summary: Check that __cplusplus is defined before comparing its value
Product: WebKit Reporter: Alberto Garcia <berto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: benjamin, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2012-10-01 04:28:09 PDT
There's this condition in WTF/wtf/Compiler.h: #if GCC_VERSION_AT_LEAST(4, 7, 0) && __cplusplus >= 201103L If __cplusplus is not defined is interpreted as having the value 0, but it produces a compilation warning with -Wundef. This is the case with some API tests that are written in C (JSNode.c, JSNodeList.c, minidom.c).
Attachments
Patch (1.29 KB, patch)
2012-10-01 04:31 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2012-10-01 04:31:01 PDT
Created attachment 166449 [details] Patch
Xan Lopez
Comment 2 2012-10-01 05:04:41 PDT
Comment on attachment 166449 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-10-01 05:28:31 PDT
Comment on attachment 166449 [details] Patch Clearing flags on attachment: 166449 Committed r130039: <http://trac.webkit.org/changeset/130039>
WebKit Review Bot
Comment 4 2012-10-01 05:28:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.