Summary: | [Forms] Adding DateTimeWeekFieldElement for multiple fields "week" input UI | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||
Component: | Forms | Assignee: | yosin | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tkent | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 97877 | ||||||||||
Attachments: |
|
Description
yosin
2012-09-30 22:21:30 PDT
Created attachment 166414 [details]
Patch 1
Comment on attachment 166414 [details]
Patch 1
Could you review this patch?
Thanks in advance.
Comment on attachment 166414 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166414&action=review > Source/WebCore/ChangeLog:8 > + THis patch is a preparation of implementing multiple fields date/time THis -> This BTW, this paragraph looks unnecessary. The next paragraph has enough information. > Source/WebCore/html/shadow/DateTimeFieldElements.cpp:344 > + : DateTimeNumericFieldElement(document, fieldOwner, 1, 53, "--") We had better define a static const variable for "53", or add a static const member to DateComponents. Created attachment 166427 [details]
Patch 2
Comment on attachment 166427 [details]
Patch 2
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Add constant DateComponents::maximumWeekOfYearNumber and miniumWeekOfYear.
Comment on attachment 166427 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166427&action=review > Source/WebCore/platform/DateComponents.cpp:48 > +const int DateComponents::minimumWeekOfYearNumber = 1; > + > +// HTML5 specification defines maximum week of year is 53. > +const int DateComponents::maximumWeekOfYearNumber = 53; IMO, minimumWeekNumber and maximumWeekNumber are better. DateComponents::maxWeekNumberInYear() and DateComponents::parseWeek() should use them. Created attachment 166430 [details]
Patch 3
Comment on attachment 166430 [details]
Patch 3
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Rename maximumWeekOfYearNumber to maximumWeekNumber.
* Rename minimumWeekOfYearNumber to minimumWeekNumber.
* Use maximumWeekNumber in DateComponents::maxWeekNumberInYear()
* Use minimumWeekNumber in parseWeek()
Comment on attachment 166430 [details]
Patch 3
ok
Comment on attachment 166430 [details] Patch 3 Clearing flags on attachment: 166430 Committed r130018: <http://trac.webkit.org/changeset/130018> All reviewed patches have been landed. Closing bug. |