Bug 97926

Summary: Garden-o-matic sometimes thinks buildbot warnings are failures
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, dglazkov, dpranke, schenney, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Ojan Vafai
Reported 2012-09-28 11:30:13 PDT
Garden-o-matic sometimes things buildbot warnings are failures
Attachments
Patch (3.48 KB, patch)
2012-09-28 11:31 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2012-09-28 12:12 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-09-28 11:31:00 PDT
Created attachment 166284 [details] Patch
Ojan Vafai
Comment 2 2012-09-28 12:12:40 PDT
Created attachment 166289 [details] Patch
Tony Chang
Comment 3 2012-09-28 12:15:03 PDT
Comment on attachment 166289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166289&action=review > Tools/ChangeLog:3 > + Garden-o-matic sometimes things buildbot warnings are failures things -> thinks > Tools/ChangeLog:9 > + It turns out the JSON clearly tells us if it's a failure. We don't need to > + search the text for the word "warning" and hope it's right. I would reword this to make it clear that we want to ignore all warnings.
Tony Chang
Comment 4 2012-09-28 12:15:27 PDT
Comment on attachment 166289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166289&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:59 > - return step.results[0] > 0 && !step.text.some(isWarning); > + return step.results[0] == 2; This could use a comment about the different values.
Ojan Vafai
Comment 5 2012-09-28 12:17:50 PDT
Committed r129930: <http://trac.webkit.org/changeset/129930>
Note You need to log in before you can comment on or make changes to this bug.