Bug 97925

Summary: virtual directories should just rename the beginning of the test path
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dpranke, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
change webkit-flow-rendering-layer-compositing back to ImageOnlyFailure ojan: review+

Ojan Vafai
Reported 2012-09-28 11:13:35 PDT
See http://trac.webkit.org/changeset/129923 compositing/regions/webkit-flow-renderer-layer-compositing.html becomes platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-layer-platform/chromium/virtual/softwarecompositing.html, because of 382 VirtualTestSuite('platform/chromium/virtual/softwarecompositing', 383 'compositing', 384 ['--enable-software-compositing']),
Attachments
Patch (7.24 KB, patch)
2012-09-28 12:20 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
change webkit-flow-rendering-layer-compositing back to ImageOnlyFailure (7.25 KB, patch)
2012-09-28 12:26 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen Chenney
Comment 1 2012-09-28 11:17:50 PDT
Fixing this will address http://code.google.com/p/chromium/issues/detail?id=152954
Dirk Pranke
Comment 2 2012-09-28 12:20:10 PDT
Created attachment 166290 [details] Patch
Alexandre Elias
Comment 3 2012-09-28 12:23:20 PDT
Comment on attachment 166290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166290&action=review Thanks, sorry about that. > LayoutTests/platform/chromium/TestExpectations:2485 > +webkit.org/b/84900 platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-layer-compositing.html [ Skip ] Let's change this one back to ImageOnlyFailure.
Ojan Vafai
Comment 4 2012-09-28 12:26:36 PDT
Comment on attachment 166290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166290&action=review Thanks for the quick fix! > Tools/Scripts/webkitpy/layout_tests/port/test.py:244 > + tests.add('passes/test-virtual-passes.html') Nit: For good measure, how about "passes/passes/test-virtual-passes.html"? You could imagine future code trying to be clever and rename directories and accidentally renaming both directories. > LayoutTests/platform/chromium/TestExpectations:2485 > +webkit.org/b/84900 platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-layer-compositing.html [ Skip ] Can unskip this now and make an ImageOnlyFailure
Dirk Pranke
Comment 5 2012-09-28 12:26:45 PDT
Created attachment 166292 [details] change webkit-flow-rendering-layer-compositing back to ImageOnlyFailure
Dirk Pranke
Comment 6 2012-09-28 12:27:18 PDT
(In reply to comment #3) > (From update of attachment 166290 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166290&action=review > > Thanks, sorry about that. > No problem, not your bug :). > > LayoutTests/platform/chromium/TestExpectations:2485 > > +webkit.org/b/84900 platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-layer-compositing.html [ Skip ] > > Let's change this one back to ImageOnlyFailure. Done.
Dirk Pranke
Comment 7 2012-09-28 12:28:30 PDT
(In reply to comment #4) > (From update of attachment 166290 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166290&action=review > > Thanks for the quick fix! > > > Tools/Scripts/webkitpy/layout_tests/port/test.py:244 > > + tests.add('passes/test-virtual-passes.html') > > Nit: For good measure, how about "passes/passes/test-virtual-passes.html"? You could imagine future code trying to be clever and rename directories and accidentally renaming both directories. > Sure, will add. > > LayoutTests/platform/chromium/TestExpectations:2485 > > +webkit.org/b/84900 platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-layer-compositing.html [ Skip ] > > Can unskip this now and make an ImageOnlyFailure
Dirk Pranke
Comment 8 2012-09-28 12:37:34 PDT
Committed r129932: <http://trac.webkit.org/changeset/129932>
Note You need to log in before you can comment on or make changes to this bug.