Bug 97924

Summary: [Chromium] WebFrameImpl.cpp could use a style cleanup
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, jamesr, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-09-28 11:00:00 PDT
[Chromium] WebFrameImpl.cpp could use a style cleanup
Attachments
Patch (70.18 KB, patch)
2012-09-28 11:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (70.17 KB, patch)
2012-09-28 11:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-28 11:01:17 PDT
Created attachment 166280 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2012-09-28 11:03:44 PDT
Comment on attachment 166280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166280&action=review > Source/WebKit/chromium/src/WebFrameImpl.cpp:2147 > + return IntRect(frame()->selection()->bounds(false)); Would ternary if be good here?
Adam Barth
Comment 3 2012-09-28 11:06:21 PDT
Comment on attachment 166280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166280&action=review >> Source/WebKit/chromium/src/WebFrameImpl.cpp:2147 >> + return IntRect(frame()->selection()->bounds(false)); > > Would ternary if be good here? Sure.
Adam Barth
Comment 4 2012-09-28 11:08:45 PDT
Created attachment 166282 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-09-28 11:30:57 PDT
Comment on attachment 166282 [details] Patch for landing Clearing flags on attachment: 166282 Committed r129927: <http://trac.webkit.org/changeset/129927>
WebKit Review Bot
Comment 6 2012-09-28 11:31:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.