Bug 97909

Summary: [chromium] REGRESSION(r129825): Page popup don't open any more
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, keishi, pilgrim, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch webkit.review.bot: commit-queue-

Keishi Hattori
Reported 2012-09-28 07:03:46 PDT
PagePopupChromeClient doesn't implement platformPageClient() so screen rect is zero. And it is causing DOMWindow.resizeTo to always resize to zero.
Attachments
Patch (2.01 KB, patch)
2012-09-28 07:22 PDT, Keishi Hattori 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-09-28 07:18:49 PDT
Rolled out: https://bugs.webkit.org/show_bug.cgi?id=97474#c20
Keishi Hattori
Comment 2 2012-09-28 07:22:03 PDT
Reopening to attach new patch.
Keishi Hattori
Comment 3 2012-09-28 07:22:05 PDT
Created attachment 166248 [details] Patch
Mark Pilgrim (Google)
Comment 4 2012-09-28 07:24:39 PDT
(In reply to comment #3) > Created an attachment (id=166248) [details] > Patch This won't work anymore because we rolled out the original patch already.
WebKit Review Bot
Comment 5 2012-09-28 07:47:56 PDT
Comment on attachment 166248 [details] Patch Attachment 166248 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14065284
Note You need to log in before you can comment on or make changes to this bug.