Bug 97895 – [GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

When handling a custom URI scheme request it's very useful to know the web view that initiated the request.

[Carlos Garcia Campos]

Created attachment 166223 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Review Bot]

Attachment 166223 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitURISchemeRequest.h"
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 166223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166223&action=review

Okay. This looks good to me. I wish there was a cleaner way to get the frame from the networking request, but

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:700
> +    uint64_t* initiatingPageIDPtr = g_slice_new(uint64_t);

You should use FastAlloc instead of the GLib allocator here.

>> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703
>> +                           reinterpret_cast<GDestroyNotify>(initiatingPageIDPtrFree));
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please fix this before landing.

[Martin Robinson]

(In reply to comment #4)
> (From update of attachment 166223 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166223&action=review
> 
> Okay. This looks good to me. I wish there was a cleaner way to get the frame from the networking request, but

...a little bit of ugliness is probably okay for now. :)

[Carlos Garcia Campos]

Committed r130259: <http://trac.webkit.org/changeset/130259>