Bug 97894

Summary: [Qt] Make NRWT use wk2/TestExpectations file
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, dpranke, galpeter, kkristof, ojan, ossy, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
updated patch none

Csaba Osztrogonác
Reported 2012-09-28 04:48:37 PDT
After https://trac.webkit.org/changeset/129788 many tests starting to fail on Qt WK2, because now NRWT uses only wk2/Skipped file, but not wk2/TestExpectations. Fix is coming soon.
Attachments
Patch (4.34 KB, patch)
2012-09-28 05:25 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
updated patch (4.95 KB, patch)
2012-09-28 06:21 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-09-28 05:25:23 PDT
Created attachment 166224 [details] Patch
Csaba Osztrogonác
Comment 2 2012-09-28 05:29:22 PDT
Additionally I removed the unnecessary skip list functions.
Peter Gal
Comment 3 2012-09-28 05:56:30 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=166224&action=review > Tools/Scripts/webkitpy/layout_tests/port/qt.py:148 > + if self.get_option('webkit_test_runner'): > + paths.append('wk2') Here is a loss of check for Qt 5.0, but if the webkit_test_runner is true it is wk2 by default. Am I right? > Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:98 > + if case['use_webkit2']: > + case['search_paths'].append("wk2") This could lead to some strange things if I'm not mistaken. Like: if the test_baseline_search_path method executes after this.
Csaba Osztrogonác
Comment 4 2012-09-28 06:21:17 PDT
(In reply to comment #3) > View in context: https://bugs.webkit.org/attachment.cgi?id=166224&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/qt.py:148 > > + if self.get_option('webkit_test_runner'): > > + paths.append('wk2') > > Here is a loss of check for Qt 5.0, but if the webkit_test_runner is true it is wk2 by default. Am I right? WK2 build is impossible with Qt 4.8, so running WK2 test with Qt 4.8 will fail because of missing WTR, search path won't be real problem. :) > > Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:98 > > + if case['use_webkit2']: > > + case['search_paths'].append("wk2") > > This could lead to some strange things if I'm not mistaken. Like: if the test_baseline_search_path method executes after this. Good point. Will fix.
Csaba Osztrogonác
Comment 5 2012-09-28 06:21:32 PDT
Created attachment 166237 [details] updated patch
Peter Gal
Comment 6 2012-09-28 06:27:34 PDT
(In reply to comment #5) > Created an attachment (id=166237) [details] > updated patch LBTM :)
Simon Hausmann
Comment 7 2012-09-28 06:43:07 PDT
Comment on attachment 166237 [details] updated patch rs=me
Csaba Osztrogonác
Comment 8 2012-09-28 06:47:08 PDT
Comment on attachment 166237 [details] updated patch Clearing flags on attachment: 166237 Committed r129887: <http://trac.webkit.org/changeset/129887>
Csaba Osztrogonác
Comment 9 2012-09-28 06:47:14 PDT
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 10 2012-09-28 12:24:22 PDT
Sorry about this ... I forgot to check the Qt waterfall for failures :(.
Note You need to log in before you can comment on or make changes to this bug.