Bug 97890 – Web Inspector: Profiles: taking heap snapshot causes error message in console.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

Actual problem is that proxy loader is closed twice.

"_snapshotReceived" should never try to close receiver,
because it is a callback fired by close.

Also minor glitches fixed:
 - taking snapshot shows "Loading..." status first,
and then "Saving xxx%";
 - after all chunks are sent "Parsing" status is set and
then is replaced with "Saving 100%";
 - "Loading %d\%" is not localized.

Created attachment 166206 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 166206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166206&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:898
> +        var status = this._savingToFile ? "Saving\u2026 %d\%" : "Loading\u2026 %d\%";

We prefer localizeble string literals always to be within UIString(), even if it may be a bit more code.
Also, now that this handles both saving and loading, I think the method could be renamed to something more generic.

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:903
> +    _updateSnapshotStatus: function() {

style: { => next line

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:1022
> +            "Loading\u2026 %d\%", (source.loadedSize() * 100 / source.fileSize()).toFixed(2));

Can we reuse saveStatusUpdate() here?

Comment on attachment 166206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166206&action=review

>> Source/WebCore/inspector/front-end/HeapSnapshotView.js:898
>> +        var status = this._savingToFile ? "Saving\u2026 %d\%" : "Loading\u2026 %d\%";
> 
> We prefer localizeble string literals always to be within UIString(), even if it may be a bit more code.
> Also, now that this handles both saving and loading, I think the method could be renamed to something more generic.

Done.

>> Source/WebCore/inspector/front-end/HeapSnapshotView.js:903
>> +    _updateSnapshotStatus: function() {
> 
> style: { => next line

Fixed

>> Source/WebCore/inspector/front-end/HeapSnapshotView.js:1022
>> +            "Loading\u2026 %d\%", (source.loadedSize() * 100 / source.fileSize()).toFixed(2));
> 
> Can we reuse saveStatusUpdate() here?

Done.

Created attachment 166215 [details]
Patch

Created attachment 166473 [details]
Patch

rebased

[Yury Semikhatsky]

Comment on attachment 166473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166473&action=review

> Source/WebCore/ChangeLog:18
> +         - removed edad code in proxy;

typo: edad -> dead

> Source/WebCore/inspector/front-end/HeapSnapshotView.js:967
> +            this._updateTransferProgress(0, 0);

Should it be (0, this._totalNumberOfChunks) ?

Comment on attachment 166473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166473&action=review

>> Source/WebCore/ChangeLog:18
>> +         - removed edad code in proxy;
> 
> typo: edad -> dead

oops. fixed

>> Source/WebCore/inspector/front-end/HeapSnapshotView.js:967
>> +            this._updateTransferProgress(0, 0);
> 
> Should it be (0, this._totalNumberOfChunks) ?

Sure.

Created attachment 166618 [details]
Patch

[WebKit Review Bot]

Comment on attachment 166618 [details]
Patch

Clearing flags on attachment: 166618

Committed r130269: <http://trac.webkit.org/changeset/130269>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.