Bug 97888

Summary: Add appearance tests for multiple fields month input UI
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97299    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

Description yosin 2012-09-28 04:07:05 PDT 
This is a part of multiple fields month input UI tests.
Comment 1 yosin 2012-09-28 04:27:07 PDT 
Created attachment 166205 [details]
Patch 1
Comment 2 WebKit Review Bot 2012-09-28 04:31:06 PDT 
Attachment 166205 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/TestExpectations:3598:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3599:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3600:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/chromium/TestExpectations:3601:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/efl/TestExpectations:1421:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/mac/TestExpectations:812:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/win/TestExpectations:1987:  Path does not exist.  [test/expectations] [5]
LayoutTests/platform/qt/TestExpectations:2721:  Path does not exist.  [test/expectations] [5]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 yosin 2012-09-30 18:37:33 PDT 
Comment on attachment 166205 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 4 Kent Tamura 2012-09-30 20:53:54 PDT 
Comment on attachment 166205 [details]
Patch 1

The patch has no tests.
Please check what you uploaded before asking review.
Comment 5 yosin 2012-09-30 21:32:57 PDT 
Created attachment 166404 [details]
Patch 2
Comment 6 Build Bot 2012-09-30 21:57:14 PDT 
Comment on attachment 166404 [details]
Patch 2

Attachment 166404 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14086658

New failing tests:
http/tests/workers/terminate-during-sync-operation.html
Comment 7 yosin 2012-09-30 23:06:23 PDT 
Comment on attachment 166404 [details]
Patch 2

Could you review this patch?
Thanks in advance.

P.S.
cr-linux passed for multiple fields month input UI tests. Although, unrelated tests are failed.

= Changes since the last review =
* Added tests which were missed in previous patch.
Comment 8 Kent Tamura 2012-10-01 00:44:08 PDT 
Comment on attachment 166404 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=166404&action=review

> LayoutTests/ChangeLog:34
> +        * platform/efl/TestExpectations: Changed to disable tests for multiple fields month input UI.
> +        * platform/mac/TestExpectations: ditto
> +        * platform/qt/TestExpectations: ditto
> +        * platform/win/TestExpectations: ditto

Need to update platform/gtk/TextExpectations and platform/chromium-android/TestExpectations too.
Comment 9 yosin 2012-10-01 00:52:01 PDT 
Created attachment 166418 [details]
Patch 3
Comment 10 yosin 2012-10-01 00:53:32 PDT 
Comment on attachment 166418 [details]
Patch 3

Could you review this change?
Thanks in advance.

= Changes since the last review =
* Add test expectations for chromium-android and gtk
Comment 11 Kent Tamura 2012-10-01 00:56:17 PDT 
Comment on attachment 166418 [details]
Patch 3

ok
Comment 12 yosin 2012-10-01 00:58:44 PDT 
Comment on attachment 166418 [details]
Patch 3

Clearing flags on attachment: 166418

Committed r130010: <http://trac.webkit.org/changeset/130010>
Comment 13 yosin 2012-10-01 00:58:50 PDT 
All reviewed patches have been landed.  Closing bug.