Bug 97862

Summary:

Use Localizer in PagePopupController

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

New Bugs

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

keishi, mifenton, morrita, rwlbuis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

96351

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing 2	webkit.review.bot: commit-queue-

Kent Tamura

Reported 2012-09-27 22:27:48 PDT

Use Localizer in PagePopupController

Attachments
Patch (13.58 KB, patch) 2012-09-27 22:50 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch for landing (13.56 KB, patch) 2012-09-28 01:03 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch for landing 2 (13.56 KB, patch) 2012-09-28 01:06 PDT, Kent Tamura	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2012-09-27 22:50:13 PDT

Created attachment 166144 [details] Patch

Hajime Morrita

Comment 2 2012-09-28 00:53:26 PDT

Comment on attachment 166144 [details] Patch You can do * operator without revealding the raw pointer througth get(). Otherwise look good.

Kent Tamura

Comment 3 2012-09-28 01:03:30 PDT

Created attachment 166165 [details] Patch for landing

WebKit Review Bot

Comment 4 2012-09-28 01:06:13 PDT

Comment on attachment 166165 [details] Patch for landing Rejecting attachment 166165 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Hajime Morrita found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14070115

Kent Tamura

Comment 5 2012-09-28 01:06:56 PDT

Created attachment 166168 [details] Patch for landing 2 Morrita -> Morita

Kent Tamura

Comment 6 2012-09-28 01:07:58 PDT

(In reply to comment #4) > Hajime Morrita found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. I copied your name from Bugzilla :-D

WebKit Review Bot

Comment 7 2012-09-28 01:10:02 PDT

Comment on attachment 166168 [details] Patch for landing 2 Rejecting attachment 166168 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ColorChooserUIController.h patching file Source/WebKit/chromium/src/DateTimeChooserImpl.cpp Hunk #1 FAILED at 40. Hunk #2 succeeded at 56 (offset 1 line). Hunk #3 succeeded at 130 (offset 2 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/DateTimeChooserImpl.cpp.rej patching file Source/WebKit/chromium/src/DateTimeChooserImpl.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14064155

Kent Tamura

Comment 8 2012-09-28 01:29:19 PDT

Committed r129860: <http://trac.webkit.org/changeset/129860>

Note You need to log in before you can comment on or make changes to this bug.