Bug 97828

Summary:

[WIN] Add WebCore::getRegistryValue()

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Bug Depends on:

102787

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Patrick R. Gansterer

Reported 2012-09-27 16:08:54 PDT

[WIN] Add WebCore::getRegistryValue()

Attachments
Patch (9.34 KB, patch) 2012-09-27 16:13 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2012-09-27 16:13:11 PDT

Created attachment 166088 [details] Patch

Brent Fulgham

Comment 2 2012-11-19 17:10:26 PST

Comment on attachment 166088 [details] Patch Another niceset of clean ups. Thanks!

Brent Fulgham

Comment 3 2012-11-19 17:10:56 PST

Comment on attachment 166088 [details] Patch R=me

WebKit Review Bot

Comment 4 2012-11-19 17:36:37 PST

Comment on attachment 166088 [details] Patch Clearing flags on attachment: 166088 Committed r135217: <http://trac.webkit.org/changeset/135217>

WebKit Review Bot

Comment 5 2012-11-19 17:36:40 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 6 2012-11-19 23:46:05 PST

It broke the Qt Win build: C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1660) : error C2144: syntax error : 'int' should be preceded by ';' C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1660) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1660) : error C2470: 'IQueryAssociations' : looks like a function definition, but there is no parameter list; skipping apparent body C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C2146: syntax error : missing ';' before identifier 'IConnectionPoint' C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C2378: 'interface' : redefinition; symbol cannot be overloaded with a typedef C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1660) : see declaration of 'interface' C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C2146: syntax error : missing ';' before identifier 'IConnectionPoint' C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : error C2086: 'int IConnectionPoint' : redefinition C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1860) : see declaration of 'IConnectionPoint' C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\Include\shlwapi.h(1863) : error C2061: syntax error : identifier 'IConnectionPoint'

Csaba Osztrogonác

Comment 7 2012-11-19 23:58:28 PST

Speculative fix landed in http://trac.webkit.org/changeset/135259. Let's see if it works.

Note You need to log in before you can comment on or make changes to this bug.