Bug 97820 – Fix issue with ClassList which was hitting an assert in debug mode

• Component: New Bugs
• Status: RESOLVED FIXED

[Erik Arvidsson]

Fix issue with ClassList which was hitting an assert in debug mode

[Erik Arvidsson]

Created attachment 166056 [details]
Patch

[Erik Arvidsson]

Created attachment 166060 [details]
Patch

[Erik Arvidsson]

Committed r129798: <http://trac.webkit.org/changeset/129798>

[Erik Arvidsson]

Comment on attachment 166060 [details]
Patch

I landed manually

[Darin Adler]

Comment on attachment 166060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166060&action=review

> Source/WebCore/bindings/v8/V8Binding.h:232
> -    Vector<T> toNativeArguments(const v8::Arguments& args, size_t startIndex)
> +    Vector<T> toNativeArguments(const v8::Arguments& args, int startIndex)
>      {
>          ASSERT(startIndex <= args.Length());
>          Vector<T> result;
>          typedef NativeValueTraits<T> TraitsType;
> -        size_t length = args.Length();
> -        for (size_t i = startIndex; i < length; ++i)
> +        int length = args.Length();
> +        for (int i = startIndex; i < length; ++i)
>              result.append(TraitsType::nativeValue(args[i]));

Did you include this change intentionally, or by accident? Why doesn’t the change log mention this change?

[Erik Arvidsson]

(In reply to comment #5)
> Did you include this change intentionally, or by accident? Why doesn’t the change log mention this change?

That was an intended change. Sorry for not pointing it out in the changelog.

The reason was that, in debug mode, the code fails to compile due to comparison between int and size_t.

[Eric Seidel (no email)]

Comment on attachment 166060 [details]
Patch

Cleared review? from attachment 166060 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).