| Summary: | [Perftest] PerfTestRunner exception when using nested git checkouts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Florin Malita <fmalita> | ||||
| Component: | Tools / Tests | Assignee: | Florin Malita <fmalita> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77037 | ||||||
| Attachments: |
|
||||||
Created attachment 166018 [details]
Patch
Let me verify that it works correctly in svn checkouts. Comment on attachment 166018 [details] Patch Clearing flags on attachment: 166018 Committed r129804: <http://trac.webkit.org/changeset/129804> All reviewed patches have been landed. Closing bug. |
I'm using separate Chromium and WebKit git trees, and run-perf-tests bombs when attempting to collect revision info: Traceback (most recent call last): File "Tools/Scripts/run-perf-tests", line 40, in <module> sys.exit(PerfTestsRunner().run()) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 167, in run exit_code = self._generate_and_show_results() File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 182, in _generate_and_show_results output = self._generate_results_dict(self._timestamp, options.description, options.platform, options.builder_name, options.build_number) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 208, in _generate_results_dict contents[name + '-revision'] = self._host.scm().svn_revision(path) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 255, in svn_revision git_log = self._run_git(['log', '-25', path]) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 106, in _run_git return self.run(full_command_args, **full_kwargs) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 76, in run decode_output=decode_output) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 423, in run_command (error_handler or self.default_error_handler)(script_error) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 340, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'git', u'log', u'-25', u'/mnt/screamin/src/chromium/src/build']" exit_code: 128 cwd: /mnt/screamin/src/chromium/src/third_party/WebKit It boils down to git not supporting querying resources outside its current tree: fmalita@fmalita-linux2:~/wk$ git log /mnt/screamin/src/chromium/src/build fatal: '/mnt/screamin/src/chromium/src/build' is outside repository