Bug 97786

Summary: Web Inspector: provide memory instrumentation for ListHashSet
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, dglazkov, japhet, joepeck, keishi, loislo, mjs, peter+ews, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch after one more rebase
vsevik: review+
Patch for landing (after rebase) none

Yury Semikhatsky
Reported 2012-09-27 07:45:39 PDT
Existing implementation of ListHashSet memory instrumentation is only approximation. We should implement one that would take into account inline capacity.
Attachments
Patch (19.19 KB, patch)
2012-09-27 08:11 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (20.28 KB, patch)
2012-09-27 08:19 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (20.94 KB, patch)
2012-09-28 01:21 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (21.00 KB, patch)
2012-09-28 02:26 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (19.94 KB, patch)
2012-09-28 04:55 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch after one more rebase (19.96 KB, patch)
2012-10-03 04:57 PDT, Yury Semikhatsky 		vsevik: review+
DetailsFormatted DiffDiff
Patch for landing (after rebase) (20.53 KB, patch)
2012-10-24 01:26 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-09-27 08:11:14 PDT
Created attachment 166004 [details] Patch
Yury Semikhatsky
Comment 2 2012-09-27 08:19:52 PDT
Created attachment 166008 [details] Patch
Yury Semikhatsky
Comment 3 2012-09-27 08:20:16 PDT
(In reply to comment #2) > Created an attachment (id=166008) [details] > Patch addInstrumentedCollection was removed as it is not used any more.
WebKit Review Bot
Comment 4 2012-09-27 09:04:19 PDT
Comment on attachment 166008 [details] Patch Attachment 166008 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14034843
Build Bot
Comment 5 2012-09-27 09:06:11 PDT
Comment on attachment 166008 [details] Patch Attachment 166008 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13967084
Peter Beverloo (cr-android ews)
Comment 6 2012-09-27 10:10:41 PDT
Comment on attachment 166008 [details] Patch Attachment 166008 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14037846
Yury Semikhatsky
Comment 7 2012-09-28 01:21:29 PDT
Created attachment 166170 [details] Patch
Yury Semikhatsky
Comment 8 2012-09-28 02:26:15 PDT
Created attachment 166183 [details] Patch
Ilya Tikhonovsky
Comment 9 2012-09-28 03:06:04 PDT
Comment on attachment 166183 [details] Patch lgtm
Yury Semikhatsky
Comment 10 2012-09-28 04:55:13 PDT
Created attachment 166211 [details] Patch
Yury Semikhatsky
Comment 11 2012-10-02 22:49:40 PDT
Maciej, can you take a look?
Yury Semikhatsky
Comment 12 2012-10-03 04:57:39 PDT
Created attachment 166856 [details] Patch after one more rebase
Yury Semikhatsky
Comment 13 2012-10-22 21:53:32 PDT
We discussed this with Maciej on #webkit channel and he was fine with the approach but wouldn't have time for detailed review soon. Could someone else do the detailed review?
Vsevolod Vlasov
Comment 14 2012-10-24 01:12:45 PDT
Comment on attachment 166856 [details] Patch after one more rebase View in context: https://bugs.webkit.org/attachment.cgi?id=166856&action=review > Source/WTF/ChangeLog:22 > + (WTF::::sizeInBytes): added a mthod that returns size of the set in bytes including method
Yury Semikhatsky
Comment 15 2012-10-24 01:26:04 PDT
Created attachment 170342 [details] Patch for landing (after rebase)
Yury Semikhatsky
Comment 16 2012-10-24 01:26:23 PDT
(In reply to comment #14) > (From update of attachment 166856 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166856&action=review > > > Source/WTF/ChangeLog:22 > > + (WTF::::sizeInBytes): added a mthod that returns size of the set in bytes including > > method Done.
Yury Semikhatsky
Comment 17 2012-10-24 02:16:27 PDT
Committed r132331: <http://trac.webkit.org/changeset/132331>
Note You need to log in before you can comment on or make changes to this bug.