Bug 9778

Summary:

[Drosera] Organize the file resource pull-down by tab/window

Product:

WebKit

Reporter:

Alice Liu <alice.barraclough>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Enhancement

CC:

vladimir.olexa

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch	timothy: review-
Screenshot with FileBrowser in place	none
Patch Revised	timothy: review+
Screenshot with changes from the revised patch	none

Alice Liu

Reported 2006-07-07 11:37:09 PDT

the file resource popup menu is just a flat list, which can get confusing when you have multiple tabs. It would be nice to organize this list with sublists for each window/tab.

Attachments
Patch (141.80 KB, patch) 2006-10-10 09:07 PDT, Vladimir Olexa (vladinecko)	timothy: review-	Details Formatted Diff Diff
Screenshot with FileBrowser in place (180.42 KB, image/jpeg) 2006-10-10 10:38 PDT, Vladimir Olexa (vladinecko)	no flags	Details
Patch Revised (140.91 KB, patch) 2006-10-10 11:34 PDT, Vladimir Olexa (vladinecko)	timothy: review+	Details Formatted Diff Diff
Screenshot with changes from the revised patch (107.87 KB, image/jpeg) 2006-10-10 11:35 PDT, Vladimir Olexa (vladinecko)	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2006-07-07 20:24:21 PDT

Great idea! I have been considering a sidebar with a tree of all the files, like Xcode.

Vladimir Olexa (vladinecko)

Comment 2 2006-10-05 07:13:22 PDT

Can this bug be merged with Bug 9596? http://bugs.webkit.org/show_bug.cgi?id=9596 I'm currently working on both features at the same time and will be releasing them in one patch.

Vladimir Olexa (vladinecko)

Comment 3 2006-10-10 09:07:45 PDT

Created attachment 11016 [details] Patch Ok, I added this functionality to Drosera. I only commented out (as opposed to removing) most of the code that was handling the files pop-up menu as I will be placing the function pop-up list there as mentioned in Bug 9596.

Timothy Hatcher

Comment 4 2006-10-10 10:31:23 PDT

Comment on attachment 11016 [details] Patch Please attach a screenshot of what Drosera looks like with this change. We will want to keep the file popup menu to be consistent with what Xcode does, it shows all open files in that menu. Right now Drosera has no way to close files, but it should (similar to bug 9895). Please make a new patch that keeps the file popup menu. What was your change to Drosera/English.lproj/Debugger.nib?

Timothy Hatcher

Comment 5 2006-10-10 10:31:57 PDT

I am very curious how this looks! Thanks for tackling it.

Vladimir Olexa (vladinecko)

Comment 6 2006-10-10 10:38:08 PDT

Created attachment 11017 [details] Screenshot with FileBrowser in place

Timothy Hatcher

Comment 7 2006-10-10 10:46:59 PDT

Comment on attachment 11017 [details] Screenshot with FileBrowser in place Cool! I don't think we should wrap the long site addresses, they should have tooltips using the title attribute. We should also use overflow-y: auto so the scrollbar gutter hides when it isn't needed.

Vladimir Olexa (vladinecko)

Comment 8 2006-10-10 11:34:16 PDT

Created attachment 11018 [details] Patch Revised - changed overflow from scroll to auto to hide the scrollbar when it's not needed - changed site text from bold to normal - site name no longer wraps - put the file pop-up button back

Vladimir Olexa (vladinecko)

Comment 9 2006-10-10 11:35:29 PDT

Created attachment 11019 [details] Screenshot with changes from the revised patch

Timothy Hatcher

Comment 10 2006-10-10 21:40:09 PDT

Landed in r16984.

Timothy Hatcher

Comment 11 2008-05-17 09:55:53 PDT

Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.

Note You need to log in before you can comment on or make changes to this bug.