| Summary: | [GTK] Split SVG from WebCore to work-around make limitation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||||
| Component: | New Bugs | Assignee: | Gustavo Noronha (kov) <gustavo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, pnormand, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Gustavo Noronha (kov)
2012-09-26 15:37:55 PDT
Created attachment 165889 [details]
Patch
Comment on attachment 165889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165889&action=review > Source/WebKit/gtk/GNUmakefile.am:84 > + libWebCoreSVG.la \ Shouldn't we add this only if svg is enabled? does libWebCoreSVG.la exist when svg is disabled? > Source/WebKit2/GNUmakefile.am:164 > + libWebCoreSVG.la \ Ditto. Comment on attachment 165889 [details]
Patch
Failed with pluginprocess, need further work.
Created attachment 175455 [details]
Rebased patch
The plugin process issue was about the .la order during link, the
WebCoreSVG lib needed symbols in the platform lib (well in the old
patch in WebCore) but it was listed too early in the dependency order.
Tested with a Debug 64-bit, youtube/flash works. With wk2 I tested. Also a build without SVG worked. I'd let cq or Gustavo land this if possible. Comment on attachment 175455 [details] Rebased patch Rejecting attachment 175455 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t of 9 hunks FAILED -- saving rejects to file Source/WebCore/GNUmakefile.list.am.rej patching file Source/WebKit/gtk/ChangeLog patching file Source/WebKit/gtk/GNUmakefile.am patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/GNUmakefile.am patch unexpectedly ends in middle of line Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Carlos Gar..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14965251 Committed r135538: <http://trac.webkit.org/changeset/135538> |