Bug 97735

Summary: [GTK] Split SVG from WebCore to work-around make limitation
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebased patch cgarcia: review+, webkit.review.bot: commit-queue-

Gustavo Noronha (kov)
Reported 2012-09-26 15:37:55 PDT
[GTK] Split SVG from WebCore to work-around make limitation
Attachments
Patch (41.11 KB, patch)
2012-09-26 16:01 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Rebased patch (39.69 KB, patch)
2012-11-21 09:06 PST, Philippe Normand 		cgarcia: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2012-09-26 16:01:56 PDT
Created attachment 165889 [details] Patch
Carlos Garcia Campos
Comment 2 2012-09-28 07:49:07 PDT
Comment on attachment 165889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165889&action=review > Source/WebKit/gtk/GNUmakefile.am:84 > + libWebCoreSVG.la \ Shouldn't we add this only if svg is enabled? does libWebCoreSVG.la exist when svg is disabled? > Source/WebKit2/GNUmakefile.am:164 > + libWebCoreSVG.la \ Ditto.
Gustavo Noronha (kov)
Comment 3 2012-11-13 06:04:47 PST
Comment on attachment 165889 [details] Patch Failed with pluginprocess, need further work.
Philippe Normand
Comment 4 2012-11-21 09:06:11 PST
Created attachment 175455 [details] Rebased patch The plugin process issue was about the .la order during link, the WebCoreSVG lib needed symbols in the platform lib (well in the old patch in WebCore) but it was listed too early in the dependency order.
Philippe Normand
Comment 5 2012-11-21 09:07:00 PST
Tested with a Debug 64-bit, youtube/flash works.
Philippe Normand
Comment 6 2012-11-21 09:08:08 PST
With wk2 I tested. Also a build without SVG worked.
Philippe Normand
Comment 7 2012-11-21 14:44:11 PST
I'd let cq or Gustavo land this if possible.
WebKit Review Bot
Comment 8 2012-11-22 00:10:58 PST
Comment on attachment 175455 [details] Rebased patch Rejecting attachment 175455 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t of 9 hunks FAILED -- saving rejects to file Source/WebCore/GNUmakefile.list.am.rej patching file Source/WebKit/gtk/ChangeLog patching file Source/WebKit/gtk/GNUmakefile.am patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/GNUmakefile.am patch unexpectedly ends in middle of line Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Carlos Gar..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14965251
Gustavo Noronha (kov)
Comment 9 2012-11-22 13:09:14 PST
Committed r135538: <http://trac.webkit.org/changeset/135538>
Note You need to log in before you can comment on or make changes to this bug.